1742357 - geckodriver inappropriately returns "HTTP method not allowed" for not yet implemented commands

Status: NEW

(Testing :: geckodriver, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Originally reported as: https://github.com/mozilla/geckodriver/issues/1962

Running a geckodriver command that is not handled yet a HTTP method not allowed is returned instead of HTTP unknown command.

Interesting is that I cannot see that UnknownMethod is used at all in the Rust code:

https://searchfox.org/mozilla-central/search?q=UnknownMethod&path=testing%2F&case=false&regexp=false

It would be good to get a wdspec test added for error types that we don't have yet.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All the tests for get_computed_label and get_computed_role also fail with not allowed even we don't have some implemented yet. Making that change for geckodriver might also change the error output. As such marking both of them being blocked.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

geckodriver uses the Warp crate to handle all the HTTP requests. And as it looks like this problem is known and covered by:

https://github.com/seanmonstar/warp/issues/77

James, do you see a way to get this fixed with a workaround until Warp allows more customization or better handling of 404?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Quickly discussed with James on Element but we don't see right now how to workaround. Also it's not severe enough to give it priority at the moment. Best might be to wait for a fix in warp.

Comment 4

[James Graham [:jgraham]]

I spent a bit of time looking at this, and it at least wasn't obvious how to get it working. It seems like you ought to be able to register a route that handles any request that didn't otherwise match, and set the error code in that. But I kept running into type errors which suggested that my approach wasn't quite right. In any case gettting the error code wrong here seems like it's unlikely to have a huge impact on users.

Comment 5

[Ricardo]

Good morning

I am looking the issue and I am having the same problem. I can see as the issues continue open (this one too https://github.com/mozilla/geckodriver/issues/1962 )

Do you have news about it?

Thanks!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No, we don't have an update and fixing this is actually not on our priority list. In which sense does it impact your communication with geckodriver?

Comment 7

[Ricardo]

Good morning

I can´t interact with shadow root elements showing "HTTP method not allowed" as people say in this issue or in this one https://github.com/mozilla/geckodriver/issues/1962

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We are currently working on ShadowRoot support in Marionette. So over the next few weeks the Find Element(s) from ShadowRoot commands will be available once it's in Firefox and a geckodriver release for it is out (see bug 1700097).

But it's not clear to me what exactly is problematic right now for you because the wrong error response is sent. What would make it different when HTTP unknown command would be sent?

Comment 9

[Ricardo]

Hi Henrik

I am realising this is not the correct issue. I apologize for the confusion because my problem is the bug 1700097. I will follow it.

Thanks again.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks for your feedback, and good to hear!

Comment 11

[meso5]

I am getting 'method not allowed' a lot after the introduction of the built-in free VPN. Eg here They are always http addresses, not offering https. If I disable VPN these sites work.

149.0.2 Flatpak on Debian

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to meso5 from comment #11)

I am getting 'method not allowed' a lot after the introduction of the built-in free VPN. Eg here They are always http addresses, not offering https. If I disable VPN these sites work.

Are you talking about the new built-in VPN feature only or in combination with geckodriver? If it's only for the former this is the wrong bug for it, and you most likely want to file a new bug.

Comment 13

[meso5]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #12)

Are you talking about the new built-in VPN feature only or in combination with geckodriver? If it's only for the former this is the wrong bug for it, and you most likely want to file a new bug.

Not sure if it's in combination with geckodriver so I reported it as separate bug.