1742359 - Stale WebDriverBiDiConnection instances cause extra submission for registered events

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As seen recently for log.entryAdded events related Wdspec tests the WebDriver BiDi connections are not getting correctly closed in-between (parameterized) tests, which means that a lot of subscriptions for events will remain and clutter the log until Firefox gets restarted due to eg. a change to capabilities.

Here an example of a newly added test that runs 10 parameterized variations and causing 10 log.entryAdded events to be submitted:

https://treeherder.mozilla.org/logviewer?job_id=358821989&repo=autoland&lineNumber=4133-4160

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

What's actually happening here is that for each test we drop the connection in the client, and reconnect for the next test. Hereby we do not create a new WebDriver session and as such re-connect to the previously created one.

The problem is that even we detect the closing of the WebSocket connection, we do not remove it from the list of connections for the given WebDriver session.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Proposing for M2 to help investigating wdspec test failures which right now is very hard due to the amount of unnecessary log messages.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1742359 - [webdriver-bidi] Remove closed WebSocket connection from Session.

Depends on D132062

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af594fce1140
[webdriver-bidi] Remove closed WebSocket connection from Session. r=webdriver-reviewers,jdescottes

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that the fix on this bug got already landed we have to add it to M2.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/af594fce1140