Closed Bug 1742365 Opened 4 years ago Closed 4 years ago

[Dark Mode] Suggestions to improve search results colors

Categories

(Webtools :: Searchfox, enhancement)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nhnt11, Unassigned)

References

Details

Search results look a bit jarring to me with pure white text on a gray-ish background. The link colors are also a bit too unsaturated for my taste. Finally, the "expando" arrow thing probably needs to use the page foreground color instead of hard-coding "black".

I would recommend we copy Bugzilla's dark mode colors:

foreground: rgb(210, 211, 212)
link: rgb(0, 108, 191)
link hovered: rgb(24, 151, 219)
link visited: rgb(200, 118, 255)

The foreground is not pure white? The colors are from here (along with a bunch of other dark mode colors) so unless there's a good reason I'd rather keep it as-is.

As for links, sure, I think those are the same as light mode right now, so happy to change it.

Ah, I was on writing https://github.com/mozsearch/mozsearch/pull/468 already but happy to review your PR instead.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

The foreground is not pure white? The colors are from here (along with a bunch of other dark mode colors) so unless there's a good reason I'd rather keep it as-is.
You're right, they're not pure white - I should have said "very white" or "almost pure white" - I just meant it looks too bright to me.

Let's call this fixed as the link colors were fixed and the foreground color while white is the same we use in-content. Doing something like dimming the backgrounds / foreground colors could be doable, if wanted, open to better colors tbh :)

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.