Open Bug 1742388 Opened 4 years ago Updated 4 years ago

Monitor lock not used for access of mNextRandomAccessPoint in MediaSourceDemuxer.cpp

Categories

(Core :: Audio/Video: Playback, task, P5)

Product:
Core
Component:
Audio/Video: Playback
Type:
task

Tracking

()

People

(Reporter: jesup, Unassigned)

References

(Blocks 1 open bug)

Details

In MediaSourceTrackDemuxer::DoGetSamples(), we access mNextRandomAccessPoint for a comparison before locking the monitor and modifying it.

It's possible that like mManager, it can only be modified on the TaskQueue thread, in which case it is safe to read it on that thread without the lock. From examination, this appears so, so it may just be a documentation issue in the source.

It's possible that like mManager, it can only be modified on the TaskQueue thread, in which case it is safe to read it on that thread without the lock.

Yes it seems the same case, mNextRandomAccessPoint would only be modified on the task queue, so it's safe to simply read its value without using lock on the task queue. We could have a better comment for that.

Severity: -- → N/A
Type: defect → task
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.