1742403 - Crash in [@ rayon_core::registry::WorkerThread::wait_until_cold]

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[Calixte Denizet (:calixte)]

Crash report: https://crash-stats.mozilla.org/report/index/04d89d4e-a768-4c36-89a0-b72e90211121

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll rayon_core::registry::WorkerThread::wait_until_cold third_party/rust/rayon-core/src/registry.rs:720
1 xul.dll std::sys_common::backtrace::__rust_begin_short_backtrace<rayon_core::registry::impl$2::spawn::closure$0, tuple$<> > ../09c42c45858d5f3aedfa670698275303a3d19afa/library/std/src/sys_common/backtrace.rs:125
2 xul.dll alloc::raw_vec::finish_grow<alloc::alloc::Global> ../09c42c45858d5f3aedfa670698275303a3d19afa/library/alloc/src/raw_vec.rs:507
3  @0x1b49f08a2bf 
4 xul.dll alloc::raw_vec::finish_grow<alloc::alloc::Global> ../09c42c45858d5f3aedfa670698275303a3d19afa/library/alloc/src/raw_vec.rs:513
5 xul.dll alloc::raw_vec::impl$1::reserve::do_reserve_and_handle<tuple$<ptr_mut$<u8>, void  ../09c42c45858d5f3aedfa670698275303a3d19afa/library/alloc/src/raw_vec.rs:334
6 xul.dll std::sys_common::thread_local_dtor::register_dtor_fallback ../09c42c45858d5f3aedfa670698275303a3d19afa//library/std/src/sys_common/thread_local_dtor.rs:32
7 xul.dll std::thread::local::fast::Key::try_initialize<core::cell::RefCell<enum$<core::option::Option<std::sys_common::thread_info::ThreadInfo>, 1, 18446744073709551615, Some> >, core::cell::RefCell<enum$<core::option::Option<std::sys_common::thread_info::ThreadInfo>, 1, 18446744073709551615, Some> >  ../09c42c45858d5f3aedfa670698275303a3d19afa//library/std/src/thread/local.rs:607
8 xul.dll std::sys_common::thread_info::set ../09c42c45858d5f3aedfa670698275303a3d19afa//library/std/src/sys_common/thread_info.rs:40
9 xul.dll core::ops::function::FnOnce::call_once<std::thread::impl$0::spawn_unchecked::closure$0, tuple$<> > ../09c42c45858d5f3aedfa670698275303a3d19afa/library/core/src/ops/function.rs:227

There are 29 crashes (from 17 installations) in nightly 96 with buildid 20211120215911. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1740627.

[1] https://hg.mozilla.org/mozilla-central/rev?node=36e2b3fafc78

Comment 1

[Toshihito Kikuchi [:toshi]]

It's strange that this crash spiked only on 20211120215911. Every thread starts from BaseThreadInitThunk, so having patched_BaseThreadInitThunk in the crashing stack is nothing special. We need to monitor this and see if another spike happens, but I don't think this was caused by bug 1740627.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

I don't see anything obvious here.

Comment 3

[Marco Castelluccio [:marco]]

Emilio, given that the volume here is pretty low, could you reassess the severity?

Comment 4

[BugBot [:suhaib / :marco]]

Closing because no crashes reported for 12 weeks.