1742558 - Add optional image preview support to Places

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Adding optional thumbnails support to Places, not used by the UI yet. This is built on top of the existing BackgroundPageThumbs.jsm implementation.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1742558 - Add Places Previews tombstones table. r=Standard8

Add a tombstones table for thumbnails, when places.thumbnails.enabled is true
this table is filled by an after delete trigger on moz_places.
This will then be used by PlacesThumbs to remove orphan thumbnails.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1742558 - Add a Places Previews module. r=Standard8

Add a PlacesThumbs.jsm module that offers an alternative long term storage of
thumbnails. Thumbnails are stored using md5 hash of the page url, in WebP format.
Removals happen using the moz_thumbs_tombstones table, orphans removal happens
on Places weekly maintenance.
The same moz-page-thumb: protocol that is currently used for volatile thumbnails,
can be used with Places thumbnails, by using places-thumbnails as host.
All the feature is behind the places.thumbnails.enabled pref, not enabled yet.

Depends on D131915

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22241a8445f9
Add Places Previews tombstones table. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/7fa69b62b226
Add a Places Previews module. r=Standard8

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing android build bustages in PageThumbProtocolHandler

Backout link: https://hg.mozilla.org/integration/autoland/rev/f3ca8755ab56e691e1e52ce495dc685a6636d2bb

Push with failures

Failure log

 INFO -  In file included from Unified_cpp_netwerk_protocol_res0.cpp:11:
[task 2021-12-20T15:34:41.917Z] 15:34:41     INFO -  /builds/worker/checkouts/gecko/netwerk/protocol/res/PageThumbProtocolHandler.cpp:26:10: fatal error: 'nsIPlacesPreviewsHelperService.h' file not found
[task 2021-12-20T15:34:41.917Z] 15:34:41     INFO -  #include "nsIPlacesPreviewsHelperService.h"

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

ah of course, Android doesn't have Places, i should ifdef it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90d7643c5df5
Add Places Previews tombstones table. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/106d816cc758
Add a Places Previews module. r=Standard8

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/90d7643c5df5
https://hg.mozilla.org/mozilla-central/rev/106d816cc758