174256 - remove unused arena-allocation operators on style sheets/rules

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I noticed that the mRefCnt and arena allocation hacks on nsCSSRule and
ns{CSS,HTMLCSS,HTML}StyleSheet are all unused.  alecf had problems with these
while working on bug 166147.

(While it might be nice to arena-allocate these objects, they're currently
refcounted, which is a problem.  And there are DOM issues, since all these
objects are accessible via the DOM.  So I don't see arena-allocation happening
anytime soon)

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch (mangled)

This is the patch.  It's hand edited quite a bit due to other changes in the
same areas that are in my tree.  I wrote "MANGLED" in the two spots where it
won't actually apply because I didn't bother figuring out the correct line
ranges to write in.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 102735 [details] [diff] [review]
patch (mangled)

r/sr=bzbarsky

Comment 3

[kinmoz]

Comment on attachment 102735 [details] [diff] [review]
patch (mangled)

r=[e-mail]

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 102735 [details] [diff] [review]
patch (mangled)

a=[e-mail]

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk, 2002-10-14 16:52/54/56/57 PDT.