1742564 - "TypeError: Interfaces which are exposed to the web may only be defined in a DOM WebIDL root" bustage on Windows

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Calixte Denizet (:calixte)]

I tried to build pine (rev 88549bb6b7ea4279dc2567f00568ec3fd6ac3a88) and I got this error

 1:46.19 config/makefiles/xpidl/jsdebugger.xpt
 1:46.31 Traceback (most recent call last):
 1:46.31   File "c:\mozilla-build\python3\lib\runpy.py", line 193, in _run_module_as_main
 1:46.31     "__main__", mod_spec)
 1:46.31   File "c:\mozilla-build\python3\lib\runpy.py", line 85, in _run_code
 1:46.31     exec(code, run_globals)
 1:46.31   File "c:\users\calixte\pine\python\mozbuild\mozbuild\action\webidl.py", line 20, in <module>
 1:46.31     sys.exit(log_build_task(main, sys.argv[1:]))
 1:46.31   File "c:\users\calixte\pine\python\mozbuild\mozbuild\action\util.py", line 18, in log_build_task
 1:46.31     return f(*args, **kwargs)
 1:46.31   File "c:\users\calixte\pine\python\mozbuild\mozbuild\action\webidl.py", line 16, in main
 1:46.31     manager.generate_build_files()
 1:46.31   File "c:\users\calixte\pine\dom\bindings\mozwebidlcodegen\__init__.py", line 293, in generate_build_files
 1:46.31     self._parse_webidl()
 1:46.31   File "c:\users\calixte\pine\dom\bindings\mozwebidlcodegen\__init__.py", line 417, in _parse_webidl
 1:46.31     self._generated_events_stems_as_array,
 1:46.31   File "c:\users\calixte\pine\dom\bindings\Configuration.py", line 123, in __init__
 1:46.31     "%s" % (webRoots, iface.location)
 1:46.31 TypeError: Interfaces which are exposed to the web may only be defined in a DOM WebIDL root ('c:\\Users\\Calixte\\pine\\dom\\webidl', 'c:\\Users\\Calixte\\pine\\dom\\bindings', 'c:\\users\\calixte\\pine\\obj-x86_64-pc-mingw32\\dom\\bindings'). Consider marking the interface [ChromeOnly] or [Func='nsContentUtils::IsCallerChromeOrFuzzingEnabled'] if you do not want it exposed to the web.
 1:46.31 c:/Users/Calixte/pine/obj-x86_64-pc-mingw32/dom/bindings/Animation.webidl line 18:10
 1:46.31 interface Animation : EventTarget {
 1:46.31           ^
 1:46.40 config/makefiles/xpidl/jsinspector.xpt
 1:46.68 config/makefiles/xpidl/kvstore.xpt
 1:46.69 config/makefiles/xpidl/layout_base.xpt
 1:46.75 config/makefiles/xpidl/layout_printing.xpt
 1:46.80 config/makefiles/xpidl/layout_xul_tree.xpt
 1:46.85 mozmake[4]: *** [Makefile:54: webidl.stub] Error 1
 1:46.86 mozmake[3]: *** [c:/Users/Calixte/pine/config/recurse.mk:99: dom/bindings/export] Error 2

the last possible root is lower case (see 'c:\\users\\calixte\\pine\\obj-x86_64-pc-mingw32\\dom\\bindings) and a comparison:
https://searchfox.org/mozilla-central/source/dom/bindings/Configuration.py#29
is failing (the lower case path is the basePath) because of the case.

I locally backed out:
https://hg.mozilla.org/mozilla-central/rev/d4d6aa35edcf
and the build is fine.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1741893

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I'm hitting this locally too :(

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1742564: Undo changes to paths exposed on `SiteManager` interfaces

In bug 1741893, the patch attempted to ensure that paths were all
case-sanitized at the boundary points of the SiteManager classes.
However, the mistake that was made is that some of the //public//
properties exposed by the classes are used by Mach commands, so changing
their case causes path incompatibility down-the-line.

To resolve the problem, this patch undoes all extra normcasing, and
scopes the fixes to 1741893 to the specific places where paths are
compared within site.py.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/085539d439e7
Undo changes to paths exposed on `SiteManager` interfaces r=glandium

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/085539d439e7