1742588 - test_fileconstructor.xhtml isn't actually testing anything

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P2)

Description

[Mark Banner (:standard8)]

I was looking at some ESLint items today, and noticed some undefined variables in dom/base/test/chrome/test_fileconstructor.xhtml.

On closer inspection, the test isn't actually running most of the tests it is intended to. The use of promise chaining, means that the incorrect attempt to set the preference is caught by a later rejection "test" as valid, and hence the test still passes.

Fixing this means the test does pass, so there are no code issues present, though we should obviously fix the test.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1742588 - Rewrite test_fileconstructor.xhtml with unix line endings. r?baku!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1742588 - Rewrite test_fileconstructor.xhtml to correctly run its tests. r?baku!

Depends on D131910

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/135c60fca4f1
Rewrite test_fileconstructor.xhtml with unix line endings. r=baku
https://hg.mozilla.org/integration/autoland/rev/1ea35be32e03
Rewrite test_fileconstructor.xhtml to correctly run its tests. r=baku

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1344957

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/135c60fca4f1
https://hg.mozilla.org/mozilla-central/rev/1ea35be32e03