1742595 - Local debug assertion failure !frame || frame->AccessibleType() == eImageType || frame->AccessibleType() == a11y::eHTMLImageMapType

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Tom S [:evilpie]]

Every time I run a local optimized debug build I get the following assertion failure, that I have to disable:

Assertion failure: !frame || frame->AccessibleType() == eImageType || frame->AccessibleType() == a11y::eHTMLImageMapType, at /home/tom/projects/mozilla/accessible/generic/ImageAccessible.cpp:78

Comment 1

[Eitan Isaacson [:eeejay]]

Is there any specific website or content that makes it happen, or is it on startup? Clean profile?

Comment 2

[James Teh [:Jamie]]

It's caused by a XUL image. I have a patch.

Comment 3

[Tom S [:evilpie]]

(In reply to James Teh [:Jamie] from comment #2)

It's caused by a XUL image. I have a patch.

Great! Sorry I missed the previous comment, but I also don't really know what triggers the assertion.

Comment 4

[James Teh [:Jamie]]

FWIW, I was hitting it when typing into the address bar.

Comment 5

[James Teh [:Jamie]]

Attachment: Bug 1742595: Don't throw an assertion when calling ImageAccessible::NativeState on a XUL image.

UL images use nsImageBoxFrame, not nsImageFrame.
AccessibleType() returns eNoType on nsImageBoxFrame.
Changing this to return eImageType seems a bit risky and adding a new type just for an assertion seems pointless.
Therefore, we just check the frame type.

Comment 6

[James Teh [:Jamie]]

:evilpie, would you mind testing this patch to verify it definitely fixes the assertion for you?

Comment 7

[Tom S [:evilpie]]

(In reply to James Teh [:Jamie] from comment #6)

:evilpie, would you mind testing this patch to verify it definitely fixes the assertion for you?

I can't reproduce the crash with this change.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8c0fe99587c
Don't throw an assertion when calling ImageAccessible::NativeState on a XUL image. r=eeejay

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c8c0fe99587c