1742598 - Don't apply URL encoding when query stripping happens

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P1)

Description

[Tim Huang[:timhuang]]

We will encode the URL query string when query stripping happens. This would end with an encoded URL string in the URL which doesn't match the behavior without query stripping. We shouldn't encode the URL query string when query stripping happens.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1742598 - Part 1: Add an parameter to URLParams::Serialize() to indicate if the encoding is needed for the serialization result. r?smaug!

The URL query stripping doesn't want the URLParams::Serialize() to
encode the result because it will encode the unstripped parameters. This
will change the unstripped parameters once stripping was happened.

Therefore, we introduce an parameter to URLParams::Serialize() to
disable encoding.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1742598 - Part 2: Add a test to ensure we don't encode query parameter after query stripping. r?dimi!

Depends on D131964

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76ba18f48c8b
Part 1: Add an parameter to URLParams::Serialize() to indicate if the encoding is needed for the serialization result. r=smaug,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/4bb21b3b37d1
Part 2: Add a test to ensure we don't encode query parameter after query stripping. r=dimi

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/76ba18f48c8b
https://hg.mozilla.org/mozilla-central/rev/4bb21b3b37d1