1742655 - Open/Close audio device via DeviceInputTrack

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, task, P1)

Description

[C.M.Chang[:chunmin]]

Now the audio start/stop is controlled by the AudioInputTrack's API but it is not the device-level MediaTrack. The audio start/stop should be controlled via DeviceInputTrack's API instead. The DeviceInputTrack is the source of input port for the AudioInputTracks and it's the MediaTrack that is closest to the device in MediaTrackGraph.

This involves the following tasks:

• Remove the unused functions in AudioDataListenerInterface once bug 1741959 is done.
• Implement DeviceInputTrack APIs to open/close audio device in MediaTrackGraph
• Add tests for AudioInputTrack with mock MediaTrackGraph

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Move AudioInput* implementations to cpp file

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Remove mDeviceTrackMap in MediaTrackGraph

mDeviceTrackMap only has one element since MediaTrackGraph can have only
one input device. Besides, we can get NativeInputTrack directly from
mTracks on graph thread without accessing it from mDeviceTrackMap. The
only left reason for having mDeviceTrackMap is to check if we have any
input device on Android. On Android, the default input device id is
always nullptr, so we use a hashmap to check if MediaTrackGraph contains
any input device. However, this hashmap can be replaced by a Maybe since
MediaTrackGraph can have only one input device.

Depends on D134526

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Move NativeInputTrack's ctor to cpp file

Depends on D134527

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Reword outdated comments

Depends on D134528

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Track AudioDeviceID in NativeInputTrack

NativeInputTrack should have a AudioDeviceID value indicating what
device its audio source is from

Depends on D134529

Comment 6

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Add GetNativeInputTrack

Implement a function in MediaTrackGraph to get the NativeInputTrack by a
device id

Depends on D134530

Comment 7

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Add MaxRequestedInputChannels and HasVoiceInput

Implement utility functions to query the input channel count and whether
input has voice from NativeInputTrack's users

Depends on D134531

Comment 8

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Open/Close audio input via NativeInputTrack

Depends on D134532

Comment 9

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Remove NotifyOutputData from NativeInputTrack

Comment 10

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Rename functions

Rename {Close, Open}AudioInput to {Disc, C}onnectDeviceInput

Depends on D134627

Comment 11

[C.M.Chang[:chunmin]]

Attachment: Bug 1742655 - Rename AudioInputTrack to AudioProcessingTrack

Depends on D134628

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8ba26997b4b
Move AudioInput* implementations to cpp file r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/53e7f97f8c90
Move NativeInputTrack's ctor to cpp file r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/5e5441649e64
Reword outdated comments r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/dc7fbea824ed
Track AudioDeviceID in NativeInputTrack r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/ae191833e3af
Remove mDeviceTrackMap in MediaTrackGraph r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/b0a8837110db
Add MaxRequestedInputChannels and HasVoiceInput r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/a1def130c105
Remove NotifyOutputData from NativeInputTrack r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/8cb7b8231c98
Open/Close audio input via NativeInputTrack r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/b004b579d1ce
Rename functions r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/3aef6c404e07
Rename AudioInputTrack to AudioProcessingTrack r=pehrsons

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b8ba26997b4b
https://hg.mozilla.org/mozilla-central/rev/53e7f97f8c90
https://hg.mozilla.org/mozilla-central/rev/5e5441649e64
https://hg.mozilla.org/mozilla-central/rev/dc7fbea824ed
https://hg.mozilla.org/mozilla-central/rev/ae191833e3af
https://hg.mozilla.org/mozilla-central/rev/b0a8837110db
https://hg.mozilla.org/mozilla-central/rev/a1def130c105
https://hg.mozilla.org/mozilla-central/rev/8cb7b8231c98
https://hg.mozilla.org/mozilla-central/rev/b004b579d1ce
https://hg.mozilla.org/mozilla-central/rev/3aef6c404e07