1742796 - Poor contrast with dark mode selection colors.

Status: VERIFIED FIXED

(Core :: Widget, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: image.png

STR:

• On Windows dark mode, go to any searfox page and select a link (which is blue-ish): https://searchfox.org/mozilla-central/source/widget/windows/nsLookAndFeel.cpp

ER:

• The link text is visible.

AR:

• The link text is barely visible.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: after.png

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1742796 - Use a more transparent color for dark mode / Android selection. r=#layout-reviewers

This prevents contrast issues with colors that are very similar to the
selection background.

See before / after screenshots. Selection on higher-contrasting
foregrounds still looks good.

This is the alpha channel that e.g., Bugzilla uses on dark mode
(so I didn't just mint it).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05e06b3bbdf9
Use a more transparent color for dark mode / Android selection. r=geckoview-reviewers,owlish

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/05e06b3bbdf9

Comment 5

[Giorgia Nichita, Release Desktop QA]

Reproduced the issue using an affected Nightly build from 2021-11-24.
Verified as fixed on Firefox 96.0b2 (20211207185904) across the following platforms: Windows 10 x64, macOS 10.15 and Ubuntu 20.04.