1742828 - 1.75% Base Content JS (OSX) regression on Mon November 22 2021

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a awsy performance regression from push 71332992f78f548b219f6405ca970828bd22c071. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	Base Content JS	macosx1015-64-shippable-qr		1,782,633.60 -> 1,813,760.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Andrej (:aglavic)]

Hi,
Can please you to add myself and [e-mail] to the CC list for Bug 1735482?
We don't currently have permission to view the bug which is why we're requesting this.

Comment 2

[Acasandrei Beatrice (needinfo me)]

Hello. Bug 1735482 caused the regression mentioned above by Andrej. Since we don't have access to Bug 1735482 adding us to the cc list is necessary so that we can update the field "Regressed by" from the current bug, which is part of the sheriffing process. Thank you.

Comment 3

[Mike Hommey [:glandium]]

Paul, I guess that matches improvements seen with bug 1669392?

Comment 4

[Paul Bone [:pbone]]

(In reply to Mike Hommey [:glandium] from comment #3)

Paul, I guess that matches improvements seen with bug 1669392?

Yes. that's right.

Comment 5

[Paul Bone [:pbone]]

(In reply to Acasandrei Beatrice from comment #2)

Hello. Bug 1735482 caused the regression mentioned above by Andrej. Since we don't have access to Bug 1735482 adding us to the cc list is necessary so that we can update the field "Regressed by" from the current bug, which is part of the sheriffing process. Thank you.

Done.

Comment 6

[Paul Bone [:pbone]]

Attachment: Bug 1742828 - Enable more aggressive allocation packing on MacOS r=glandium

Comment 7

[Dianna Smith [:diannaS]]

:pbone any updates on the attached revision?

Comment 8

[Paul Bone [:pbone]]

I'm waiting for another patch to land because measuring resident unique memory on MacOS is totally broken right now Bug 1743781.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3ca80551fba
Enable more aggressive allocation packing on MacOS r=glandium

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c3ca80551fba

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

Comment 12

[Andrej (:aglavic)]

== Change summary for alert #34962 (as of Fri, 29 Jul 2022 16:12:16 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
9%	perf_reftest_singletons link-style-cache-1.html	macosx1015-64-shippable-qr	e10s fission stylo webrender	267.37 -> 243.33
8%	perf_reftest_singletons link-style-cache-1.html	macosx1015-64-shippable-qr	e10s fission stylo webrender	268.27 -> 245.56

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34962

Comment 13

[Acasandrei Beatrice (needinfo me)]

== Change summary for alert #34972 (as of Mon, 01 Aug 2022 04:05:40 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	Base Content JS	macosx1015-64-shippable-qr	fission	1,632,736.00 -> 1,605,864.00
1%	Base Content JS	macosx1015-64-shippable-qr	fission	1,632,717.33 -> 1,610,344.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34972