Remove Socorro code that tags crash reports as Fission related
Categories
(Socorro :: Webapp, task, P2)
Tracking
(Not tracked)
People
(Reporter: cpeterson, Assigned: willkg)
References
Details
(Whiteboard: [fission:future] [fission:android:m4])
Attachments
(1 file)
Now that Fission is rolling out to Firefox 94 Release users and will soon be enabled by default in Nightly and Beta (bug 1732358), Socorro no longer needs to tag crash reports as possibly Fission related.
This cleanup task is not a high priority. It would just remove some code and metadata that we no longer need.
- The new bug template can stop adding "Maybe Fission related. (DOMFissionEnabled=1)" to the new bug description.
- crash-stats.mozilla.org's top crash page no longer needs to add the "Potential Fission Crash" icon (bug 1659795).
But we probably do want to keep crash reports' "dom_fission_enabled" field for 3–6 more months.
Socorro code references to Fission:
https://github.com/mozilla-services/socorro/search?p=1&q=Fission&type=code
|
||
Comment 1•2 years ago
|
||
Socorro is used for mobile as well as desktop, so do we need to keep at least some of this around for longer for whatever mobile rollout happens?
|
Reporter | |
Comment 2•2 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #1)
Socorro is used for mobile as well as desktop, so do we need to keep at least some of this around for longer for whatever mobile rollout happens?
That's a good point. We should probably keep Socorro's Fission features until we ship Android Fission. I'll tag this bug so we revisit it then.
|
Assignee | |
Comment 3•2 years ago
|
||
Thank you for writing this up!
If there are changes we can make to Crash Stats that make the fission indicators more helpful for Android Fission, let me know.
|
|
Reporter | |
Comment 4•2 years ago
|
||
Will, we've finished the Fission rollout on desktop Firefox. We'll be testing Android Fission in H2, so we'll still want to retain crash reports' "dom_fission_enabled" field so we can search for Android Fission crash, but I think we can now make these other cleanups:
- The new bug template can stop adding "Maybe Fission related. (DOMFissionEnabled=1)" to the new bug description.
- crash-stats.mozilla.org's top crash report page and signature detail page no longer needs to add the "Potential Fission Crash" message and icon (added in bug 1659795).
Should I file separate bugs to remove those? Or can we use this bug?
|
|
Assignee | |
Comment 5•2 years ago
|
||
We can keep it all in this bug--that's fine.
Grabbing this to do soon.
|
|
Assignee | |
Comment 6•2 years ago
|
||
|
|
Assignee | |
Comment 7•2 years ago
|
||
|
|
Assignee | |
Comment 8•2 years ago
|
||
I pushed this to prod just now in bug #1769264. New bugs won't have the "Maybe Fission related." line anymore. The top crashers and signature reports no longer have a "Potential Fission Crash" message.
We'll keep the dom_fission_enabled field for the foreseeable future. We tend not to remove fields until the crash annotations go away.
Given that, I think we should mark this as FIXED.
Description
•