1742959 - Do not ref-count MediaEventForwarder

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Andreas Pehrson [:pehrsons]]

Because of some issue detected by TSan, ref-counting was added to MediaEventForwarder in bug 1654112 (where in a separate patch, MediaEventForwarder was also added to the tree).

MediaEventForwarder should, like its MediaEventSource peers not be ref-counted. This bug is for trying to find another solution.

Comment 1

[Andreas Pehrson [:pehrsons]]

Michael, you don't happen to remember what the tsan issue was in some more detail do you?

Comment 2

[Andreas Pehrson [:pehrsons]]

I wonder if the root issue here could have been fixed by bug 1727262. But there was no mutex in MediaEventSource.h prior to that fix so the question remains as to which mutex we ran into problems with.

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1742959 - Do not ref-count MediaEventForwarder. r?mjf!

Comment 4

[Michael Froman [:mjf]]

(In reply to Andreas Pehrson [:pehrsons] from comment #1)

Michael, you don't happen to remember what the tsan issue was in some more detail do you?

I do not remember that off the top of my head.

Comment 5

[Michael Froman [:mjf]]

Now having gone back and looked at code, I believe you could be correct on Bug 1727262. If I remember, this was probably a shutdown race. I should have made more notes in the commit log.

Have we seen tsan runs for this change (basically reverting c34ea4d71235)?

Comment 6

[Michael Froman [:mjf]]

I see the try url in the review. Looks good.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8492028369c3
Do not ref-count MediaEventForwarder. r=mjf

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8492028369c3