Closed Bug 1742959 Opened 6 months ago Closed 6 months ago

Do not ref-count MediaEventForwarder

Categories

(Core :: WebRTC, task, P2)

task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

Details

Attachments

(1 file)

Because of some issue detected by TSan, ref-counting was added to MediaEventForwarder in bug 1654112 (where in a separate patch, MediaEventForwarder was also added to the tree).

MediaEventForwarder should, like its MediaEventSource peers not be ref-counted. This bug is for trying to find another solution.

Michael, you don't happen to remember what the tsan issue was in some more detail do you?

Flags: needinfo?(mfroman)

I wonder if the root issue here could have been fixed by bug 1727262. But there was no mutex in MediaEventSource.h prior to that fix so the question remains as to which mutex we ran into problems with.

(In reply to Andreas Pehrson [:pehrsons] from comment #1)

Michael, you don't happen to remember what the tsan issue was in some more detail do you?

I do not remember that off the top of my head.

Flags: needinfo?(mfroman)

Now having gone back and looked at code, I believe you could be correct on Bug 1727262. If I remember, this was probably a shutdown race. I should have made more notes in the commit log.

Have we seen tsan runs for this change (basically reverting c34ea4d71235)?

Flags: needinfo?(apehrson)

I see the try url in the review. Looks good.

Flags: needinfo?(apehrson)
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8492028369c3
Do not ref-count MediaEventForwarder. r=mjf
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.