Closed Bug 174298 Opened 22 years ago Closed 22 years ago

Sort important products to the top and box them in on enter bug page

Categories

(bugzilla.mozilla.org :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: justdave, Assigned: myk)

References

Details

Attachments

(1 file, 2 obsolete files)

Inspired by Gerv's b.m.o-specific patch for the query page (bug 173573), the
patch that will be attached shortly takes all the Mozilla-related products and
sorts them to the top of the product list on the choose-a-product page you get
prior to going to enter_bug.

Suggestions welcome for the wording of the "product category" headers.
Attached patch choose-product template patch (obsolete) — Splinter Review
Timeless says we should break it down into Client, Server, and Community
products, with Client at the top, Community in the middle, and Server at the
bottom (Bugzilla would fall in Server, and Browser/MailNews would be in Client).

He's working on a categorization of which should go where that he'll probably
post here soon.
QA Contact: myk → timeless
*** Bug 163944 has been marked as a duplicate of this bug. ***
I'd already filed a bug on this :-) But never mind. It's a good idea, of course.
But you must remember to have a loop which checks for products you haven't
printed yet, just so if someone adds a new product it doesn't require template
hacking for it to appear on the product list.

Gerv
Client products
> Browser Calendar CCK Chimera *Derivatives MailNews *MozillaClassic Phoenix PSM
Community projects
> Documentation "Mozilla Localizations" mozilla.org "Tech Evangelism"
Core products
> Directory NSPR NSS
Java projects
> Grendel JSS Rhino
Server products
> Bugzilla Webtools
* dead products, listed where they belong in schema for completeness.
Gerv: bbaetz thought you had already filed this, but he and I both looked and
couldn't find it.  All we found was the one proposing the same type of change to
the query page.  I reopened the one you duped.  That wasn't this.
Here's my effort. Order is significant.

Client Software
> Browser MailNews Chimera Phoenix "Mozilla Localizations" Calendar PSM
Non-code (I don't think Community is right but I'm struggling for a better name)
> Documentation mozilla.org "Tech Evangelism"
Components
> NSPR Directory NSS Rhino JSS 
Server Software
> Bugzilla Webtools
Dormant (More polite than Obsolete; and we have to list them)
> Grendel CCK Derivatives MozillaClassic

Gerv
asa: views?

Gerv
Blocks: 176570
With this patch applied, "Mozilla Translations" appears both inside the box and
in its normal position, and the one inside the box has no description.
Err, "Mozilla Localizations"
myk: see bug 173573 comment 3 - same issue
Dave: if you don't object, this evening I'll take this patch and fix it up to
use the full classification scheme suggested, along with incorporating the
"Localizations" fix.

Gerv
Gerv: go for it.
Attached patch Patch v.1 (obsolete) — Splinter Review
This is a whole new choose-product.html.tmpl which categorises all of b.m.o's
current products. Myk will have to decide whether to use custom/ or not for
this.

One thing that might be considered a bug is that it does not automatically
print new ones; this is trickier than it looks, because there is no virtual
variable method to delete from a hash :-( Still, I think this might do.

Gerv
Attachment #102759 - Attachment is obsolete: true
Comment on attachment 105505 [details] [diff] [review]
Patch v.1

This looks very cool.

>[% PROCESS header_block title = "Client Software" %]
>
>[% PROCESS prod_block names = ["Browser", "MailNews", "Chimera", "Phoenix",
>                               "Mozilla Localizations", "Calendar", "PSM"] %]

Nit: "block" isn't so informative in these block names, while "prod" takes a
second to figure out.  Also "header" describes that document section
technically instead of functionally.  I'd suggest "category" and "product" (or
something similar) in place of these.

Nit: this is easier to read when there aren't spaces around the equals sign.

Shouldn't "Mozilla Localizations" be in "Client Support" and "PSM" be in
"Components"?  After all, you can't install and run either.

>[% PROCESS prod_block names = ["Grendel", "CCK", "Derivatives", 
>                               "MozillaClassic"] %]

These don't get displayed for some reason.


>[%############################################################################%]
>[%# Block for product blocks                                                 #%]
>[%############################################################################%]

Nit: that's a bit redundant. :-)


>      <th align="right" valign="top">

These should be valign="baseline".

>        <a href="[% target %]?product=[% p FILTER url_quote %]
>                                      [%- "&amp;format=$format" IF format %]">

Doesn't PRE_CHOMP=1 take care of this chomping?
Also, this patch shouldn't show Derivatives and MozillaClassic, which are closed
to new bugs.

Is there a bug on giving Bugzilla in general this functionality?
hopefully localizations will shortly be getting the java localization tool which
is standalone (it doesn't belong to browser) :-)
Attached patch Patch v.2Splinter Review
Comments fixed. Again, this is a whole new file.

Gerv
Attachment #105505 - Attachment is obsolete: true
This is now up on b.m.o. Marking fixed.

Gerv
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Component: Bugzilla: Other b.m.o Issues → General
Product: mozilla.org → bugzilla.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: