Closed Bug 1743034 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 31749 - Add scroll smoothness check to scroll-snap test with keyboard input

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31749 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31749
Details from upstream follow.

Kevin Ellis <kevers@chromium.org> wrote:

Add scroll smoothness check to scroll-snap test with keyboard input

Previous the test only ensure that we reached the expected endpoint,
but the transition could be smooth or a sudden jump. With the patch, we
count the number of steps before reaching the endpoint. During
experimental testing, hundreds of scroll events were received during the
course of a smooth scroll. The required target was set to 2, to catch
an immediate jump and to non-flake when a testing machine is bogged
down.

Bug: 1273921
Change-Id: Ie24a5fa2795af3860fe38bdd93522dde2f39365b

Reviewed-on: https://chromium-review.googlesource.com/3302851
WPT-Export-Revision: 9912dd58c38fac3ea03dc1f0cf3d2af62ee65b9b

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

PASS : 1
FAIL : 1
TIMEOUT: 2
NOTRUN : 6

Chrome

OK : 1
PASS : 8

Safari

TIMEOUT: 2
NOTRUN : 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-scroll-snap/input/keyboard.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
Snaps to bottom-left after pressing ArrowDown: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug], PASS [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: PASS, Safari: TIMEOUT)
Snaps to top-left after pressing ArrowUp: TIMEOUT (Chrome: PASS, Safari: NOTRUN)
Snaps to top-right after pressing ArrowRight: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Snaps to top-left after pressing ArrowLeft: NOTRUN (Chrome: PASS, Safari: NOTRUN)
If the original intended offset is valid as making a snap area cover thesnapport, and there's no other snap offset in between, use the originalintended offset: NOTRUN (Chrome: PASS, Safari: NOTRUN)
If the original intended offset is valid as making a snap area cover the snapport, but there's a defined snap offset in between, use the defined snap offset.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
If there is no valid snap offset on the arrow key's direction other than the current offset, and the scroll-snap-type is mandatory, stay at the current offset.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
If there is no valid snap offset on the arrow key's direction other than the current offset, and the scroll-snap-type is proximity, go to the original intended offset: NOTRUN (Chrome: PASS, Safari: NOTRUN)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9977644b1d5b
[wpt PR 31749] - Add scroll smoothness check to scroll-snap test with keyboard input, a=testonly
https://hg.mozilla.org/integration/autoland/rev/33106bf7544d
[wpt PR 31749] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.