Closed Bug 1743037 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31750 - Fix text painting for ::target-text & ::highlight

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31750 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31750
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:

Fix text painting for ::target-text & ::highlight

::target-text & ::highlight pseudo-elements were not painting
the text if the originating element color was transparent.

This patch fixes this removing two checks
in NGHighlightPainter::Paint().

BUG=1273943
TEST=web_tests/external/wpt/css/css-highlight-api/painting/custom-highlight-painting-017.html
TEST=web_tests/external/wpt/css/css-pseudo/target-text-007.html

Change-Id: Ie8198e8cf37d6ef89cdee341e84b6bc36ad6ec84
Reviewed-on: https://chromium-review.googlesource.com/3302311
WPT-Export-Revision: 8a2212c08445495cc3fea2b557ace644a16daa90

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL : 1
TIMEOUT: 1

Chrome

FAIL : 2

Safari

FAIL : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-highlight-api/painting/custom-highlight-painting-017.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/target-text-007.html: TIMEOUT (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a725815930cf
[wpt PR 31750] - Fix text painting for ::target-text & ::highlight, a=testonly
https://hg.mozilla.org/integration/autoland/rev/03dbca486183
[wpt PR 31750] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a725815930cf
https://hg.mozilla.org/mozilla-central/rev/03dbca486183

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.