1743150 - Shorthands shouldn't be enumerated in the computed style.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1743150 - Shorthands in computed style shouldn't be enumerable. r=#style,#layout-reviewers

This is as per spec, and causes failures once we enable the pref to expose
shorthands in the computed style. We need to decouple the "enabled-ness" from
the enumerable-ness, which we do by keeping two separate arrays, and leaving
ComputedStyleMap for the enumeration.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e37fab919847
Shorthands in computed style shouldn't be enumerable. r=layout-reviewers,jfkthame

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing linux build bustage in layout/style/nsComputedDOMStyle

Backout link: https://hg.mozilla.org/integration/autoland/rev/e157111104c3cceffe54b57907f315d6f3bb7cd1

Push with failures

Failure log

INFO -  /builds/worker/workspace/obj-build/layout/style/nsComputedDOMStyleGenerated.inc:15:1: sorry, unimplemented: non-trivial designated initializers not supported
[task 2021-12-01T11:07:03.206Z] 11:07:03    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:662: Unified_cpp_layout_style3.o] Error 1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c8376ad956e
Shorthands in computed style shouldn't be enumerable. r=layout-reviewers,jfkthame

Comment 5

[Sandor Molnar[:smolnar]]

Backed out changeset 3c8376ad956e (bug 1743150) for causing multiple failures in layout/style/nsComputedDOMStyle

Backout link: https://hg.mozilla.org/integration/autoland/rev/4afd9e2b6901d9aab29dff2883a381763b3245b8

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9faf7a5f6e19
Shorthands in computed style shouldn't be enumerable. r=layout-reviewers,jfkthame

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/9faf7a5f6e19