Open Bug 1743155 Opened 6 months ago

Move <LocalizationProvider> up to <App>

Categories

(DevTools :: Debugger, task)

task

Tracking

(Not tracked)

People

(Reporter: nchevobbe, Unassigned)

References

Details

For Bug 1591025, I'm moving the strings used in WhyPanel.js onto a new .ftl file (so the PausedDebuggerOverlay can use them as well).
While making the necessary changes in the debugger, I realized that we are using React context in order to pass shortcuts, the toolbox document and an l10n instances further down the tree (see https://searchfox.org/mozilla-central/rev/65d4d3399afa79c8de5a0cc11752d2ba7c31edc1/devtools/client/debugger/src/components/App.js#299-303)
Unfortunately, if we try to render <LocalizationProvider> from <App>, the component sets a new child context, wiping the existing one.
For now, I'll only add the provider directly in <WhyPanel> , but as we migrate more things to Fluent, we might want to fix this.
l10n won't be needed anymore, but we should find alternatives for other usages (https://searchfox.org/mozilla-central/search?q=.contextTypes&path=devtools%2Fclient%2Fdebugger%2Fsrc%2F&case=true&regexp=false)

You need to log in before you can comment on or make changes to this bug.