1743169 - [@ org.mozilla.geckoview.GeckoResult$UncaughtException: at org.mozilla.geckoview.GeckoResult.dispatchLocked(GeckoResult.java) ] "nativeExtension.id must not be null"

Status: RESOLVED WONTFIX

(GeckoView :: Extensions, defect, P3)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

This crash started to show up in Fenix 96 Nightly.

java.lang.NullPointerException: nativeExtension.id must not be null
    at mozilla.components.browser.engine.gecko.webextension.GeckoWebExtension.<init>(GeckoWebExtension.kt:1)
    at mozilla.components.browser.engine.gecko.GeckoEngine$$ExternalSyntheticLambda12.onValue
    at org.mozilla.geckoview.GeckoResult.lambda$thenInternal$6(GeckoResult.java:2)
    at org.mozilla.geckoview.GeckoResult.$r8$lambda$CtmBkNQN_okuE2MBIfsimJFUi6Q(GeckoResult.java)
    at org.mozilla.geckoview.GeckoResult$$ExternalSyntheticLambda1.run
    at org.mozilla.geckoview.GeckoResult.lambda$dispatchLocked$7(GeckoResult.java:2)
    at org.mozilla.geckoview.GeckoResult.$r8$lambda$JYfUuhIZf5JetbZ-qCaWvlWcPeE(GeckoResult.java)
    at org.mozilla.geckoview.GeckoResult$$ExternalSyntheticLambda0.run
    at android.os.Handler.handleCallback(Handler.java:739)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:135)
    at android.app.ActivityThread.main(ActivityThread.java:5910)
    at java.lang.reflect.Method.invoke(Method.java)
    at java.lang.reflect.Method.invoke(Method.java:372)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1405)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1200)

org.mozilla.geckoview.UncaughtException: java.lang.NullPointerException: nativeExtension.id must not be null
    at org.mozilla.geckoview.GeckoResult.dispatchLocked(GeckoResult.java:4)
    at org.mozilla.geckoview.GeckoResult.completeExceptionally(GeckoResult.java:4)
    at org.mozilla.geckoview.GeckoResult.lambda$thenInternal$6(GeckoResult.java:10)
    at org.mozilla.geckoview.GeckoResult.$r8$lambda$CtmBkNQN_okuE2MBIfsimJFUi6Q(GeckoResult.java)
    at org.mozilla.geckoview.GeckoResult$$ExternalSyntheticLambda1.run
    at org.mozilla.geckoview.GeckoResult.lambda$dispatchLocked$7(GeckoResult.java:2)
    at org.mozilla.geckoview.GeckoResult.$r8$lambda$JYfUuhIZf5JetbZ-qCaWvlWcPeE(GeckoResult.java)
    at org.mozilla.geckoview.GeckoResult$$ExternalSyntheticLambda0.run
    at android.os.Handler.handleCallback(Handler.java:739)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:135)
    at android.app.ActivityThread.main(ActivityThread.java:5910)
    at java.lang.reflect.Method.invoke(Method.java)
    at java.lang.reflect.Method.invoke(Method.java:372)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1405)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1200)

• Sentry: https://sentry.prod.mozaws.net/operations/firefox-nightly/issues/15333408
• Fenix: https://github.com/mozilla-mobile/fenix/issues/22608

Comment 1

[Emily Toop (:fluffyemily)]

We should investigate whether this is related to custom extensions on whether this is a problem in the making that we need to deal with.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Looks like this get lumped into Crash in [@ org.mozilla.geckoview.GeckoResult$UncaughtException: at org.mozilla.geckoview.GeckoResult.dispatchLocked(GeckoResult.java)]. By filtering on nativeExtension we get a similar number of crashes as Sentry https://crash-stats.mozilla.org/signature/?java_stack_trace_raw=~nativeExtension&product=Fenix&signature=org.mozilla.geckoview.GeckoResult%24UncaughtException%3A%20at%20org.mozilla.geckoview.GeckoResult.dispatchLocked%28GeckoResult.java%29&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

I think this is a case of a corrupted disk/database, no reported crashes since Nov 24th. Let's keep monitoring it but I don't think this is going to be a problem.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

The code is in beta and we haven't seen any occurrence of this, so I'm gonna lower the priority.

Comment 5

[Chris Peterson [:cpeterson]]

Moving some extension bugs to the GeckoView::Extensions component.

Comment 6

[Chris Peterson [:cpeterson]]

https://crash-stats.mozilla.org/report/index/32ea4380-053b-4c99-9aae-315e30230306

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on nightly

:amejia, could you consider increasing the severity of this top-crash bug?

For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit BugBot documentation.

Comment 9

[Chris Peterson [:cpeterson]]

Looks like there was a regression in 108, jumping from 64 crash reports from Fenix 107 to 400+ in Fenix 108.

But the crash volume graph shows a regression starting days before Fenix 113 was released (May 9). AFAICT, all the crash stacks mention org.mozilla.fenix.addons.InstalledAddonDetailsFragment:

https://crash-stats.mozilla.org/report/index/c94ac45d-9f5d-4bb3-9ecd-a27910230611

Caused by: java.lang.NullPointerException
	at org.mozilla.fenix.addons.InstalledAddonDetailsFragment$bindAllowInPrivateBrowsingSwitch$1$1.invoke(InstalledAddonDetailsFragment.kt:26)
	at mozilla.components.feature.addons.AddonManager$setAddonAllowedInPrivateBrowsing$3.invoke(AddonManager.kt:33)
	at mozilla.components.browser.engine.gecko.GeckoEngine$$ExternalSyntheticLambda17.onValue(R8$$SyntheticClass:35)
	at org.mozilla.geckoview.GeckoResult.lambda$thenInternal$6(GeckoResult.java:11)
        ...

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Sorry for removing the keyword earlier but there is a recent change in the ranking, so the bug is again linked to a topcrash signature, which matches the following criterion:

• Top 10 AArch64 and ARM crashes on beta

For more information, please visit BugBot documentation.

Comment 11

[Arturo Mejia [:amejia]]

As this bug contains old generic stacktrace it maybe the case that other stacks are getting aggregated here
Closing in favour of https://bugzilla.mozilla.org/show_bug.cgi?id=1838321