174319 - native theme builds done on gtk+ versions < 1.2.9 look bad

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Brian Ryner (not reading)]

We rely on API's added in gtk+ 1.2.9 to get the correct metrics for scrollbars
and checkboxes (for themes that take advantage of the new API). The nightly
builds are done RedHat 6.2, which uses gtk+ 1.2.6, so the functions aren't
available.  This looks really bad on the default theme on RedHat 8.0.

The fix is to look up the symbols at runtime.  Patch coming up.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 102777 [details] [diff] [review]
patch

>+  if (checkbutton_props_func) {
>+    /*
>+     * This API is only supported in GTK+ >= 1.2.9, and gives per-theme values.
>+     */

Nit: "supported only" not "only supported".  Same for the later occurrence.

>+  if (!checkedStyleProp) {
>+    checkedStyleProp = PR_TRUE;
>+    if (gtkLibrary)
>+      style_prop_func = (style_prop_t) PR_FindSymbol(gtkLibrary, "gtk_style_get_prop_experimental");
>+    else
>+      style_prop_func = (style_prop_t) PR_FindSymbolAndLibrary("gtk_style_get_prop_experimental", &gtkLibrary);

Here and in the other place (earlier in the patch), use a static const char
array, e.g., static const char STYLE_GET_PROP_EXPERIMENTAL[] =
"gtk_style_get_prop_experimental", to avoid duplicating the string literal in
the then and else clauses.

Fix these and sr=[e-mail].

/be

Comment 3

[Stuart Parmenter]

Comment on attachment 102777 [details] [diff] [review]
patch

r=pavlov with brendan's comments

Comment 4

[Brian Ryner (not reading)]

checked in (not part of the build).