[wpt-sync] Sync PR 31761 - Use proper cleanup in dialog-focusing-steps-inert.html
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 31761 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/31761
Details from upstream follow.
Oriol Brufau <obrufau@igalia.com> wrote:
Use proper cleanup in dialog-focusing-steps-inert.html
The test was just cleaning up at the end of the test(), but the code was
not reached if some assert failed, making the following test() fail too.
The proper way to clean up is with add_cleanup().
This change makes the 2nd test pass in Firefox and Chromium.
|
Assignee | |
Comment 1•2 years ago
|
||
PR 31761 applied with additional changes from upstream: 5a6f1ee2c25aa1f01ca09d853a2e5cb3b3a43ad6
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfef64704d489520a8a46b47cc08b5c49b62d61a
|
|
Assignee | |
Comment 3•2 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 2 subtests
Status Summary
Firefox
OK : 1
FAIL: 2
Chrome
OK : 1
PASS: 1
FAIL: 1
Safari
OK : 1
FAIL: 2
Links
Details
New Tests That Don't Pass
/html/semantics/interactive-elements/the-dialog-element/dialog-focusing-steps-inert.html
dialog.show(): focusing steps should not change focus when dialog is inert: FAIL (Chrome: FAIL, Safari: FAIL)
dialog.showModal(): focusing steps should apply focus fixup rule when dialog is inert: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f25181ea69e [wpt PR 31761] - Use proper cleanup in dialog-focusing-steps-inert.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/fbfa84e24b69 [wpt PR 31761] - Update wpt metadata, a=testonly
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2f25181ea69e
https://hg.mozilla.org/mozilla-central/rev/fbfa84e24b69
Description
•