Closed Bug 1743225 Opened 1 year ago Closed 1 year ago

Return an error from AutoMemMap::initWithHandle() if MapViewOfFile() returns null

Categories

(Core :: IPC, task, P3)

Unspecified
Windows
task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox-esr91 --- wontfix
firefox94 --- wontfix
firefox95 --- wontfix
firefox96 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

As described in bug 1715975 comment 3, AutoMemMap::initWithHandle will return Ok() even if MapViewOfFile returns a null addr:

https://searchfox.org/mozilla-central/rev/519a8915c5538be2f03813e05c1a7bd8dc9f49c8/js/xpconnect/loader/AutoMemMap.cpp#111-115

initWithHandle should return an error like Err(NS_ERROR_FAILURE).

I audited the other MapViewOfFile calls in mozilla-central and they all handle the null return correctly.

Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28bdf3329f49
Return an error from AutoMemMap::initWithHandle() if MapViewOfFile() returns null. r=jld
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.