1743225 - Return an error from AutoMemMap::initWithHandle() if MapViewOfFile() returns null

Status: RESOLVED FIXED

(Core :: IPC, task, P3)

Description

[Chris Peterson [:cpeterson]]

As described in bug 1715975 comment 3, AutoMemMap::initWithHandle will return Ok() even if MapViewOfFile returns a null addr:

https://searchfox.org/mozilla-central/rev/519a8915c5538be2f03813e05c1a7bd8dc9f49c8/js/xpconnect/loader/AutoMemMap.cpp#111-115

initWithHandle should return an error like Err(NS_ERROR_FAILURE).

I audited the other MapViewOfFile calls in mozilla-central and they all handle the null return correctly.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1743225 - Return an error from AutoMemMap::initWithHandle() if MapViewOfFile() returns null. r?jld

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28bdf3329f49
Return an error from AutoMemMap::initWithHandle() if MapViewOfFile() returns null. r=jld

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/28bdf3329f49