1743365 - [Linux] Redundant nsClipboard::HasDataMatchingFlavors() calls

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

For simple text paste we perform eight calls of nsClipboard::HasDataMatchingFlavors(). We need to optimize that as HasDataMatchingFlavors() is expensive call on Linux as we spin internal event loop.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1743365 [Linux] Cache clipboard targets r?emilio

nsClipboard::HasDataMatchingFlavors() calls nsRetrievalContext::GetTargets() which obtains clipboard targets. We need to call Gtk code for that and spin evetn loop to get the targets.
In this patch we store clipboard tragets internally to speed up nsClipboard::HasDataMatchingFlavors() calls. We also listen at owner-change signal to clear target cache when clipboard content changes.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c201f6eb14d354172e5806692ed30642091d856

Comment 3

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cae0079270963653a29955167e8bca9280727d36

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/743f82451af4
[Linux] Cache clipboard targets r=emilio

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/743f82451af4

Comment 6

[Atila Butkovits]

Backed out for breaking certain combinations of tests.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0224b58f6c858dfa448501c384deb0bed9e498f6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=743f82451af4e3e6ea6a7c8653d1b0f83d73f7d9&selectedTaskRun=RcEzEnYhQkKQn9BlHgg3hw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=360110583&repo=autoland&lineNumber=3742

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The failure mentioned in comment 6 appeared after the test manifests (similar to folders) got automatically reorganized but adding the failing combination to previous pushes ("backfilling") showed the issue started with the change from this bug.

Comment 8

[Alexandru Michis [:malexandru]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/0224b58f6c858dfa448501c384deb0bed9e498f6

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Okay, let's wait to 97 cycle with it.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:stransky, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Yes, I need to fix test failures.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc42022a498187de0a85b8646a4519057c784181

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d641e4ee14e4
[Linux] Cache clipboard targets r=emilio

Comment 14

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in test_pasteImgTextarea

Backout link: https://hg.mozilla.org/integration/autoland/rev/c543d1128430790627cb6fc9848e9f66c25daa67

Push with failures

Failure log

INFO - TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_pasteImgTextarea.xhtml | paste should not be enabled in xul textareas when an image is on the clipboard - got true, expected false
[task 2021-12-22T22:46:38.330Z] 22:46:38     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:500:14
[task 2021-12-22T22:46:38.330Z] 22:46:38     INFO - @chrome://mochitests/content/chrome/editor/libeditor/tests/test_pasteImgTextarea.xhtml:22:11
[task 2021-12-22T22:46:38.330Z] 22:46:38     INFO - add_task | Leaving test 
[task 2021-12-22T22:46:38.330Z] 22:46:38     INFO - GECKO(2994) | MEMORY STAT | vsize 27687MB | residentFast 480MB | heapAllocated 207MB
[task 2021-12-22T22:46:38.330Z] 22:46:38     INFO - TEST-OK | editor/libeditor/tests/test_pasteImgTextarea.xhtml | took 152ms

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1743365 [Linux] Cache clipboard targets r?emilio

nsClipboard::HasDataMatchingFlavors() calls nsRetrievalContext::GetTargets() which obtains clipboard targets. We need to call Gtk code for that and spin evetn loop to get the targets.
In this patch we store clipboard tragets internally to speed up nsClipboard::HasDataMatchingFlavors() calls. We also listen at owner-change signal to clear target cache when clipboard content changes.

Comment 16

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c9890ba5a5f41c1376ce517a64e86a329baef40

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Hm, the try doesn't look good but I don't see any connections to the clipboard code there.

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Looks like missing cache clear in ~nsRetrievalContext().
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=83983ac0fedc7ab7df339ad69eab5ec1c6d40051

Comment 19

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bba2bae7b850cd1dcf9bd43dcbf3213e1c79a1d

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6428c9f9de09
[Linux] Cache clipboard targets r=emilio

Comment 21

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/6428c9f9de09