1743379 - [wpt-sync] Sync PR 31774 - Revert "Initial support for text-decoration-line: spelling|grammar-error"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31774 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31774
Details from upstream follow.

Greg Thompson <[e-mail]> wrote:

Revert "Initial support for text-decoration-line: spelling|grammar-error"

This reverts commit 643df2d079fac73cb420e6cd074c79d5a739f63d.

Reason for revert: text-decoration-line-grammar-error.html and text-decoration-line-spelling-error.html fail consistently on Mac10.12 Tests

Original change's description:

Initial support for text-decoration-line: spelling|grammar-error

This adds the initial support for spelling-error and grammar-error
values of text-decoration-line property.

Main changes are in TextDecorationInfo, where we need to support
the new values and paint the decoration correctly.
In Mac platform we use a dotted decoration to match
the platform conventions.
In other platforms we use a wavy decoration, but we modify it
so it looks similar to the spelling and grammar markers
in Microsoft Word.

It's important to note that this is just an intermediate step,
as this is different than how we currently paint
the spelling and grammar errors in DocumentMarkerPainter.
The idea would be make DocumentMarkerPainter use CSS text decorations
and then use this new code added here.

There are some known issues:

• The underline offset is not the same than in Microsoft Word,
  but that's because of a problem with regular underlines
  not using the font metrics to compute that offset (crbug.com/1273042).
• We should allow to tweak the color with text-decoration-color,
  added a TODO about that.

BUG=1163436

Change-Id: I117ad38fe3fc805619eb47b1df2f48c9d7c9a351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3297885
Commit-Queue: Delan Azabani \<[e-mail]>
Reviewed-by: Delan Azabani \<[e-mail]>
Reviewed-by: Stephen Chenney \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#945876}

Bug: 1163436
Change-Id: I2622bde37f2f8a7f725a1a06be8d34acdf9f728b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306392
Auto-Submit: Greg Thompson \<[e-mail]>
Owners-Override: Greg Thompson \<[e-mail]>
Commit-Queue: Rubber Stamper \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#945903}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 31774 applied with additional changes from upstream: 3ee257b18ef0fcb1c6346c9d3b760922b26673c6

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e76b360156836aedb2afd864a694766397d01ee

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ee0f8311b6b
[wpt PR 31774] - Revert "Initial support for text-decoration-line: spelling|grammar-error", a=testonly

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8ee0f8311b6b