1743418 - Use SharedData and JSProcessActor to improve URLQueryStrippingListService

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Tim Huang[:timhuang]]

We can improve our URLQueryStrippingListService according to the phabricator comment. Moving to use SharedData and JSProcessActor can help us to remove URLQueryStrippingListService.jsm from the startup scripts of the content processes.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

(Somehow this shows up in the Fission bug list, but I don't think there is anything Fission specific here)

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1743418 - Part 1: Use shared data to populate remote settings list to content processes. r?pbz

We used to use the message manager to get query stripping list from the
parent process during the startup of content processes as well as the
list gets updated from remote settings.

In this patch, we change to use the shared data to populate the list for
remote settings. This brings one benefit that we don't need to start the
list service during the startup of content processes in order to get the
list as early as possible. We can get the list lazily because the shard
data will be preloaded during the process startup.

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1743418 - Part 2: Remove URLQueryStrippingListProcessScript.js and URLQueryStrippingListService.jsm from the known list in browser startup tests. r?mconley

Depends on D132990

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ab00f31e2ed
Part 1: Use shared data to populate remote settings list to content processes. r=pbz
https://hg.mozilla.org/integration/autoland/rev/9f7117a4ffb7
Part 2: Remove URLQueryStrippingListProcessScript.js and URLQueryStrippingListService.jsm from the known list in browser startup tests. r=mconley

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1ab00f31e2ed
https://hg.mozilla.org/mozilla-central/rev/9f7117a4ffb7

Comment 6

[Andrej (:aglavic)]

== Change summary for alert #32718 (as of Tue, 14 Dec 2021 18:13:13 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	Base Content JS	linux1804-64-shippable-qr		1,822,548.00 -> 1,812,018.00
1%	Base Content JS	macosx1015-64-shippable-qr		1,850,707.64 -> 1,840,904.00
0.48%	Base Content JS	linux1804-64-shippable-qr		1,820,482.67 -> 1,811,832.00
0.47%	Base Content JS	windows10-64-2004-shippable-qr		1,825,922.67 -> 1,817,256.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32718