1743523 - Pagination links shows less buttons for the last pages

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:

1. go to https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=8b868de0bb21d8d3b69d5e51ff3911fbfd1b03bd&newProject=try&newRevision=b9b9b261915ac099d1bbb38ed3e4f6cb6fad59e9&framework=13&page=1
2. click "»" in the pagination
3. click "‹" in the pagination
4. click "‹" in the pagination
5. click "‹" in the pagination
6. click "‹" in the pagination
7. click "‹" in the pagination

Actual result:
Pagination shows:

1. "1 2 3 4 5 › »"
2. "« ‹ 66"
3. "« ‹ 65 66 ›"
4. "« ‹ 64 65 66 ›"
5. "« ‹ 63 64 65 66 ›"
6. "« ‹ 62 63 64 65 66 ›"
7. "« ‹ 61 62 63 64 65 › »"

Expected result:
Pagination shows:

1. "1 2 3 4 5 › »"
2. "« ‹ 62 63 64 65 66"
3. "« ‹ 62 63 64 65 66 ›"
4. "« ‹ 62 63 64 65 66 ›"
5. "« ‹ 62 63 64 65 66 ›"
6. "« ‹ 62 63 64 65 66 ›"
7. "« ‹ 61 62 63 64 65 › »"

I guess this is by design that the first button becomes the current page, but it would be better always showing 5 buttons if there are 5+ pages.

also related to bug 1743520 to make the buttons' position consistent

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: GitHub Pull Request

Comment 2

[Tooru Fujisawa [:arai]]

actually, the "Expected result" matches the behavior when there's 5 or less pages.
The issue happens only when there's 6+ pages.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://github.com/mozilla/treeherder/commit/afb477809c13ff9fa3cc8756547067b818487676