Make it possible to mark all jobs in a job group by clicking the group name or somewhere
Categories
(Tree Management :: Treeherder, enhancement)
Tracking
(Not tracked)
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(2 files, 1 obsolete file)
Steps to reproduce:
- open https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=fd3f8ed9727034c73c05b4dad8b1fd7cdf7a6c89
- click the triangle button
- click "Add new jobs"
- add all jobs in "Linux 18.04 x64 WebRender Shippable Btime"
Actual result:
You need to click all of items inside "Linux 18.04 x64 WebRender Shippable Btime" one by one
Expected result:
clicking "Btime" enables all items there
Assignee | ||
Comment 1•3 years ago
|
||
maybe "clicking the group name" isn't the right action.
currently it's assigned for toggling the open/close state of the group.
Comment 2•3 years ago
|
||
Comment 3•3 years ago
•
|
||
Hi, thanks for filing the bug. In the future, please need-info the triage owner to ask for a bug to be assigned to you before submitting a patch. This also allows for discussion about the bug you've filed.
After reading your steps to reproduce, its not clear to me what the issue is after clicking "add new jobs". Can you please clarify what you mean. Screenshots might be helpful here.
Assignee | ||
Comment 4•3 years ago
|
||
The issue is step 4 in the STR.
There are many jobs under "Btime", and to trigger all of them, you need to select them by clicking one by one, that has the following issue:
- clicking one by one is simply tedious
- clicking again de-select the job, so you cannot randomly click everywhere until all of them is selected
- enabling the job adds border to the job name, that changes the element's size, and reflow happens, and the position of the job changes, that makes it harder to select all of them
Comment 5•3 years ago
|
||
I understand the desire to have a one click solution, but I'm hesitant to enable such a feature since its a departure from the current expected behavior and users have no way of knowing that click one Btime test will trigger all of them. There might be some other work-arounds in the UI or with taskcluster CLI tools that can help reduce the tedium of retriggering those jobs. Aryx, do you have any thoughts or suggestions?
![]() |
||
Comment 6•3 years ago
|
||
In general, this is a good addition and will be mostly used by people pushing to Try which want to add tests afterwards.
- As Sarah mentioned, this should be discoverable. Ideally in the tooltip for the group and on https://treeherder.mozilla.org/userguide
- The metaKey won't work on Windows at least: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey Please use a modifier which works on every platform.
Assignee | ||
Comment 7•3 years ago
|
||
what if we show "All" button next to the group name?
Something like:
Btime [All] (allrecipes allrecipes-vismet ...)
![]() |
||
Comment 8•3 years ago
|
||
Sounds good to me for requesting additional tasks. For other modes (e.g. failure classification), it should not be visible.
Comment 9•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Description
•