1743538 - Clear MOZ_FIX_LINK_PATHS on macOS

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1743538 - Remove MOZ_FIX_LINK_PATHS.

AFAIK, MOZ_FIX_LINK_PATHS was only necessary back when we were building
XPCOM binary components that linked against libxul.

Comment 2

[Mike Hommey [:glandium]]

Landry, Petr, can you check the attached patch doesn't break your builds?

Comment 3

[Petr Sumbera]

It breaks Solaris build. The symptoms are still the same as in original bug 1419321.

Comment 4

[Landry Breuil (:gaston)]

sorry, cant test, hadnt built m-c locally in a while and it seems broken for me :

68:30.78 In file included from Unified_cpp_aec3_factory_gn0.cpp:2:                                                     
68:30.78 In file included from /home/landry/src/m-c/third_party/libwebrtc/api/audio/echo_canceller3_factory.cc:14:                                                                                                                             
68:30.78 In file included from /home/landry/src/m-c/third_party/libwebrtc/modules/audio_processing/aec3/echo_canceller3.h:30:                                                                                                                  
68:30.78 In file included from /home/landry/src/m-c/third_party/libwebrtc/rtc_base/race_checker.h:15:                  
68:30.79 /home/landry/src/m-c/third_party/libwebrtc/rtc_base/platform_thread_types.h:47:1: error: unknown type name 'PlatformThreadId'                                                                                                         
68:30.79 PlatformThreadId CurrentThreadId();                                                                                                                                                                                                   
68:30.79 ^                                         
68:30.79 /home/landry/src/m-c/third_party/libwebrtc/rtc_base/platform_thread_types.h:52:1: error: unknown type name 'PlatformThreadRef'                                                                                                        
68:30.79 PlatformThreadRef CurrentThreadRef();                                                                                                                                                                                                 
68:30.79 ^                                                                                                             
68:30.80 /home/landry/src/m-c/third_party/libwebrtc/rtc_base/platform_thread_types.h:55:29: error: unknown type name 'PlatformThreadRef'                                                                                                       
68:30.80 bool IsThreadRefEqual(const PlatformThreadRef& a, const PlatformThreadRef& b);                                                                                                                                                        
68:30.80                             ^                                                                                 
68:30.81 /home/landry/src/m-c/third_party/libwebrtc/rtc_base/platform_thread_types.h:55:57: error: unknown type name 'PlatformThreadRef'                                                                                                       
68:30.81 bool IsThreadRefEqual(const PlatformThreadRef& a, const PlatformThreadRef& b);   

no time to dig further, sadly

Comment 5

[Mike Hommey [:glandium]]

(In reply to Petr Sumbera from comment #3)

It breaks Solaris build. The symptoms are still the same as in original bug 1419321.

Does -rpath-link work instead of -L?

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1743538 - Clear MOZ_FIX_LINK_PATHS on macOS.

-executable-path is not a supported option in lld, and doesn't appear to
be necessary anymore with ld64.

Comment 7

[Petr Sumbera]

(In reply to Mike Hommey [:glandium] from comment #5)

(In reply to Petr Sumbera from comment #3)

It breaks Solaris build. The symptoms are still the same as in original bug 1419321.

Does -rpath-link work instead of -L?

No, it doesn't. I haven't investigated deeper but it simply gives following errors:

 1:52.85 error: linking with `/builds/psumbera/mozilla-central-build/build/cargo-linker` failed: exit status: 1
 1:52.85   |
 1:52.85   = note: "/builds/psumbera/mozilla-central-build/build/cargo-linker" "-m64" "-L" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.0.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.1.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.10.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.11.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.12.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.13.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.14.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.2.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.3.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.4.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.5.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.6.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.7.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.8.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.build_script_build.9uh2mos9-cgu.9.rcgu.o" "-o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/serde_derive-cff7f2f74fd9b71d/build_script_build-cff7f2f74fd9b71d.3dyq7fuydzz8cw3b.rcgu.o" "-Wl,-zignore" "-nodefaultlibs" "-L" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/deps" "-L" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib" "-Wl,--start-group" "-Wl,-Bstatic" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libstd-511e774961cca64d.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libpanic_unwind-4b36165ebaeb1e70.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libminiz_oxide-05f2b3af23469790.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libadler-16ea365dc58dd3a2.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libobject-182cdf81c62b25e3.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libaddr2line-ecbe3a17c682f60c.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libgimli-7b0d904f8e2c750c.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libstd_detect-97f0fa02613f95d3.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/librustc_demangle-218ea8ed856de960.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libhashbrown-9a84e9626aed5812.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/librustc_std_workspace_alloc-7a0ecd5030356e01.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libunwind-4f268532f55eb7ea.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libcfg_if-75dfcc59e7c4f8ea.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/liblibc-b6be12ce0d3cec84.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/liballoc-79ed5be5dd3c1d9f.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/librustc_std_workspace_core-3ddeabd019884b1d.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libcore-e78b3c9376095726.rlib" "-Wl,--end-group" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libcompiler_builtins-aa8cb0c066bdff2b.rlib" "-Wl,-Bdynamic" "-lsocket" "-lposix4" "-lpthread" "-lresolv" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread"
 1:52.85   = note: gcc: error: unrecognized command line option '-rpath-link=/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/bin'
 1:52.86 error: aborting due to previous error
 1:52.89 error: could not compile `serde_derive`

Comment 8

[Petr Sumbera]

(In reply to Petr Sumbera from comment #7)

(In reply to Mike Hommey [:glandium] from comment #5)

(In reply to Petr Sumbera from comment #3)

It breaks Solaris build. The symptoms are still the same as in original bug 1419321.

Does -rpath-link work instead of -L?

No, it doesn't. I haven't investigated deeper but it simply gives following errors:

1:52.85 = note: gcc: error: unrecognized command line option '-rpath-link=/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/bin'

Seems that -rpath-link is not supported on Solaris:
https://mail.haskell.org/pipermail/ghc-devs/2013-January/000151.html

When I tried:
-Wl,-rpath-link,${DIST}/bin

I got:
 1:58.96 error: linking with `/builds/psumbera/mozilla-central-build/build/cargo-linker` failed: exit status: 1
 1:58.96   |
 1:58.96   = note: "/builds/psumbera/mozilla-central-build/build/cargo-linker" "-m64" "-L" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.0.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.1.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.10.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.11.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.12.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.13.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.14.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.15.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.2.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.3.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.4.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.5.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.6.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.7.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.8.rcgu.o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.build_script_build.85ck6r77-cgu.9.rcgu.o" "-o" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/build/proc-macro2-d8390725198a26db/build_script_build-d8390725198a26db.345q60v3zku12ixh.rcgu.o" "-Wl,-zignore" "-nodefaultlibs" "-L" "/builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/debug/deps" "-L" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib" "-Wl,--start-group" "-Wl,-Bstatic" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libstd-511e774961cca64d.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libpanic_unwind-4b36165ebaeb1e70.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libminiz_oxide-05f2b3af23469790.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libadler-16ea365dc58dd3a2.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libobject-182cdf81c62b25e3.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libaddr2line-ecbe3a17c682f60c.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libgimli-7b0d904f8e2c750c.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libstd_detect-97f0fa02613f95d3.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/librustc_demangle-218ea8ed856de960.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libhashbrown-9a84e9626aed5812.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/librustc_std_workspace_alloc-7a0ecd5030356e01.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libunwind-4f268532f55eb7ea.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libcfg_if-75dfcc59e7c4f8ea.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/liblibc-b6be12ce0d3cec84.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/liballoc-79ed5be5dd3c1d9f.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/librustc_std_workspace_core-3ddeabd019884b1d.rlib" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libcore-e78b3c9376095726.rlib" "-Wl,--end-group" "/builds/psumbera/rustc-1.53.0/lib/rustlib/x86_64-pc-solaris/lib/libcompiler_builtins-aa8cb0c066bdff2b.rlib" "-Wl,-Bdynamic" "-lsocket" "-lposix4" "-lpthread" "-lresolv" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread"
 1:58.96   = note: ld: elf error: file /builds/psumbera/mozilla-central-build/obj-x86_64-pc-solaris2.11/dist/bin: elf_begin: I/O error: region read: Is a directory
 1:58.96           collect2: error: ld returned 1 exit status
 1:58.96 error: aborting due to previous error
 1:59.00 error: could not compile `proc-macro2`

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bed7be5677e
Clear MOZ_FIX_LINK_PATHS on macOS. r=firefox-build-system-reviewers,andi

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7bed7be5677e