1743566 - Tracking the update to NSPR 4.33

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Kai Engert (:KaiE:)]

Next NSPR version will be 4.33

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Bug 1743566 - NSPR_4_33_BETA1. r=glandium UPGRADE_NSPR_RELEASE

Comment 2

[Kai Engert (:KaiE:)]

glandium, you said you want that asap. We could push this to autoland today, and if there aren't any issues, we could release NSPR next week (and change m-beta to pick up the final version number).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/858579234cb9
NSPR_4_33_BETA1. r=glandium UPGRADE_NSPR_RELEASE

Comment 4

[Kai Engert (:KaiE:)]

Hubert, we assume the changes in the dependent bugs don't change ABI.

Comment 5

[Kai Engert (:KaiE:)]

(In reply to Kai Engert (:KaiE:) from comment #4)

Hubert, we assume the changes in the dependent bugs don't change ABI.

Comment 6

[Hubert Kario]

Is there a branch I can check out, compile and test for the differences?

Comment 7

[Kai Engert (:KaiE:)]

Hubert, you can either obtain tag NSPR_4_33_BETA1 from hg.mozilla.org/projects/nspr or alternatively, simply apply the following patch, which is the only change on top of 4.32 that we have so far:
https://hg.mozilla.org/integration/autoland/raw-rev/858579234cb9

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/858579234cb9

Comment 9

[Kai Engert (:KaiE:)]

Attachment: Bug 1743566 - Finalize NSPR version number (no code change). r=glandium UPGRADE_NSPR_RELEASE

Comment 10

[Kai Engert (:KaiE:)]

FF Beta 96 already uses all of the code that was released today as NSPR 4.33 RTM.

We need to record that the version number is that of a final release, and we should require this version at build time.

Setting needinfo for glandium, because I'll be away soon (early next week).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb8db07031a6
Finalize NSPR version number (no code change). r=glandium UPGRADE_NSPR_RELEASE DONTBUILD

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/eb8db07031a6

Comment 13

[Kai Engert (:KaiE:)]

Comment on attachment 9255929 [details]
Bug 1743566 - Finalize NSPR version number (no code change). r=glandium UPGRADE_NSPR_RELEASE

Beta/Release Uplift Approval Request

• User impact if declined: none.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): no code change, just a version number change
• String changes made/needed:

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9255929 [details]
Bug 1743566 - Finalize NSPR version number (no code change). r=glandium UPGRADE_NSPR_RELEASE

approved for 96.0b7

Comment 15

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/13db8afbc9b6