Non-scrollable page can hide dynamic toolbar
Categories
(Core :: Panning and Zooming, defect, P3)
Tracking
()
People
(Reporter: tnikkel, Unassigned)
References
Details
Load https://neartalk.makeworld.space/ and scroll up and down. You can show/hide the dynamic toolbar, but the page is not scrollable so the dynamic toolbar should always be shown.
This seems sensitive to at least the dev pixel ratio and maybe other things. I can consistently reproduce when running a local x86 build in the emulator, it has a dev pixel ratio of 2. On a real phone with dev pixel ratio of ~2.6 I do not see the problem.
(This came up in bug 1738696 where I can only reproduce the original bug when we correctly always show the dynamic toolbar.)
Bug 1652190 initially implemented this I think. One thing I see from that bug is this line
should potentially be a fuzzy comparison. What I mean is that sometimes due to rounding issues the composition bounds are slightly smaller than the scrollable rect, but in reality they are the same size.
Comment 1•2 years ago
|
||
Would definitely be nice to fix but the symptoms are not particularly severe so going with S3.
Description
•