Closed Bug 1743613 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31792 - Find glyph coverage via HarfBuzzFace

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31792 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31792
Details from upstream follow.

Dominik Röttsches <drott@chromium.org> wrote:

Find glyph coverage via HarfBuzzFace

This improves congruence between glyph coverage during hyphenation
and shaping. CoreText API on Mac returns coverage for U+2010 while
the font does not actually have such a glyph (the CoreText API is
called when calling Skia's unicharToGlyph on a Mac SkTypeface).

In such a case, hyphenation will introduce a U+2010 character
to the line end, which will then not find coverage during shaping,
as character coverage functions in HarfBuzz do not
synthesize this glyph.

It will also improve correctness as retrieval of the hyphenation
character respects unicode-range for the font.

Bug: 1267606
Change-Id: I06ed0501d81124f2a0258f4e08ef4e763ad1b151

Reviewed-on: https://chromium-review.googlesource.com/3306480
WPT-Export-Revision: c3d1a395d1acd651e9fb6c7e357ba9a5174ae45f

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/860bbd8a4420
[wpt PR 31792] - Find glyph coverage via HarfBuzzFace, a=testonly

https://hg.mozilla.org/mozilla-central/rev/860bbd8a4420

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.