failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIWinTaskbar.getTaskbarProgress] in _attachIndicator@resource:///modules/DownloadsTaskbar.jsm under Windows running headless
Categories
(Firefox :: Headless, defect, P5)
Tracking
()
People
(Reporter: nalexander, Unassigned, Mentored)
Details
(Keywords: good-first-bug)
Just an irritation: --headless tests cause lots of log spew like:
0:18.29 INFO Console message: [JavaScript Error: "[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIWinTaskbar.getTaskbarProgress]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource:///modules/DownloadsTaskbar.jsm :: _attachIndicator :: line 133" data: no]"]
_attachIndicator@resource:///modules/DownloadsTaskbar.jsm:133:41
registerIndicator@resource:///modules/DownloadsTaskbar.jsm:100:14
_schedulePerWindowIdleTasks/<@chrome://browser/content/browser.js:2326:30
idleTaskRunner@chrome://browser/content/browser.js:2280:11
|
Reporter | |
Comment 1•4 years ago
|
||
There are many ways to address this, but I'd like to go fairly near to the roots. Let's make WinTaskbar::GetAvailable and WinTaskbar::Initialize no-ops when we're running under headless mode, around https://searchfox.org/mozilla-central/rev/1c3f5a29f0000619667c419e9ae74897138cb975/widget/windows/WinTaskbar.cpp#294.
This could be a good mentored ticket. Follow the commit that fixed Bug 1740513 to see how to check for IsHeadless. We might need to skip some tests if we're headless in https://searchfox.org/mozilla-central/source/browser/components/downloads/test/browser/browser.ini. I'm not quite sure how to run mochitests headless in try to test this just yet.
|
|
Reporter | |
Comment 2•4 years ago
|
||
(In reply to Nick Alexander :nalexander [he/him] from comment #1)
There are many ways to address this, but I'd like to go fairly near to the roots. Let's make
WinTaskbar::GetAvailableandWinTaskbar::Initializeno-ops when we're running under headless mode, around https://searchfox.org/mozilla-central/rev/1c3f5a29f0000619667c419e9ae74897138cb975/widget/windows/WinTaskbar.cpp#294.
bdahl: have you an opinion on this versus other approaches?
|
||
Comment 3•4 years ago
|
||
Would it be possible to prevent WinTaskbar from being creating in the first place in headless mode? If that's looking more complicated, adding a few checks as you mentioned above sounds fine to me too.
|
||
Comment 4•4 years ago
|
||
Can someone assign this bug to me please? I would like to work on it as part of my outreachy application process.
|
|
Reporter | |
Comment 5•4 years ago
|
||
(In reply to onyemakonorambrose from comment #4)
Can someone assign this bug to me please? I would like to work on it as part of my outreachy application process.
Generally I prefer to assign after work is started. So: post a patch and the Bugzilla autobot will assign you. Good luck!
|
||
Comment 6•4 years ago
|
||
(In reply to onyemakonorambrose from comment #4)
Can someone assign this bug to me please? I would like to work on it as part of my outreachy application process.
Hey are you still planning to work on this one?
|
||
Comment 7•3 years ago
|
||
hello, I kindly request to work on this please. I am am outreachy applicant
|
|
Reporter | |
Comment 8•3 years ago
|
||
(In reply to briannapatricia7 from comment #7)
hello, I kindly request to work on this please. I am am outreachy applicant
Generally I prefer to assign after a patch is submitted. It can feel like there's a shortage of mentor-able bugs but please, don't worry -- nobody is going to scoop this away.
Start with seeing if you can do what Brendan suggested in #c3, and if it's too hard, fall back to #c1. I'll mark assigned after there's a Phabricator patch and some back-and-forth.
|
|
||
Comment 9•3 years ago
|
||
thanks Nick, lemme
Description
•