1743882 - Screenshots component preference observer

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement)

Description

[Niklas Baumgardner [:niklas]]

Currently the screenshots component is hidden behind screenshots.browser.component.enabled and when the preference is flipped to true, the browser needs to be restarted before the screenshots component works.

Comment 1

[Sam Foster [:sfoster] (he/him)]

You should be able to use Services.prefs.addObserver for this. We already observe the extension's pref in _monitorScreenshotsPref it might make sense to expand on that.

We already enable the actors based on the pref, so I think you'll just need to make sure the entry points for the context menu, toolbar and key command do the right thing, and potentially call Screenshots.initialize() when the component pref goes true.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1743882 - Screenshots component preference observer. r=sfoster!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63ec4612926b
Screenshots component preference observer. r=sfoster

Comment 4

[Iulian Moraru]

Backed out for causing mochitest failures on browser_preferences_usage.js.

Push with failures

Failure log

Backout link

[task 2021-12-10T01:18:32.549Z] 01:18:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.zoom.full should be accessed at most 110 times. - 102 <= 110 - 
[task 2021-12-10T01:18:32.551Z] 01:18:32     INFO - Buffered messages finished
[task 2021-12-10T01:18:32.552Z] 01:18:32     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | extensions.screenshots.disabled should not be accessed more than 40 times. - 51 <= 40 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js :: checkPrefGetters :: line 42
[task 2021-12-10T01:18:32.553Z] 01:18:32     INFO - Stack trace:
[task 2021-12-10T01:18:32.554Z] 01:18:32     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:checkPrefGetters:42
[task 2021-12-10T01:18:32.555Z] 01:18:32     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:navigate_around:302
[task 2021-12-10T01:18:32.557Z] 01:18:32     INFO - toolkit.telemetry.cachedClientID should not be accessed more than 40 times and was accessed 50 times.
[task 2021-12-10T01:18:32.558Z] 01:18:32     INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | browser.startup.record should not be accessed more than 40 times. - 12 <= 40 - 

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b6141189876
Screenshots component preference observer. r=sfoster

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7b6141189876