1743893 - 1.65 - 1.38% Base Content JS / Base Content JS + 2 more (Linux, OSX, Windows) regression on Mon November 29 2021

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a awsy performance regression from push 385267bb6f1bb85642b568d873a6231b73600c0a. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	Base Content JS	macosx1015-64-shippable-qr		1,830,168.00 -> 1,860,408.00
1%	Base Content JS	windows10-64-2004-shippable-qr		1,808,504.00 -> 1,833,576.00
1%	Base Content JS	windows10-64-2004-shippable-qr		1,808,448.00 -> 1,833,560.00
1%	Base Content JS	linux1804-64-shippable-qr		1,803,167.33 -> 1,828,136.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Tim Huang[:timhuang]]

The regression is because we start loading the URLQueryStrippingListService.jsm during the startup of content processes. We have opened bug 1743418 to improve the situation and I plan to implement it in the next release. Also, this will only affect the Nightly channel because the query stripping is currently only enabled in the Nightly channel. Therefore, I think the regression won't be a problem in short term.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1742582

Comment 3

[Tim Huang[:timhuang]]

Given that Bug 1743418 was fixed, could we verify if the regression was fixed?

Comment 4

[Andrej (:aglavic)]

An improvement alert has appeared for that Bug 1743418, we verified that the regression was fixed!

It had the following improvements:
== Change summary for alert #32718 (as of Tue, 14 Dec 2021 18:13:13 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	Base Content JS	linux1804-64-shippable-qr		1,822,548.00 -> 1,812,018.00
1%	Base Content JS	macosx1015-64-shippable-qr		1,850,707.64 -> 1,840,904.00
0.48%	Base Content JS	linux1804-64-shippable-qr		1,820,482.67 -> 1,811,832.00
0.47%	Base Content JS	windows10-64-2004-shippable-qr		1,825,922.67 -> 1,817,256.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32718

Comment 5

[Tim Huang[:timhuang]]

Given comment 4, I think we can resolve this bug.