1743914 - Allow to use Windows UserChoice default mechanisms for additional file extensions, including PDF

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement, P2)

Description

[Nick Alexander :nalexander [he/him]]

Bug 1703578 added a general Windows UserChoice implementation, and used it for "https", "http", ".html", ".htm". This ticket tracks generalizing the interface just a little bit further, to additional file extensions, in particular allowing to set Firefox as the default PDF handler.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1743914 - Part 1: Allow UserChoice to set Firefox as the default handler for arbitrary file extensions. r?mhowell

This is a straight-forward extension of the existing UserChoice
mechanism to arbitrary file extensions. This is not a broad
generalization but we don't foresee many extensions beyond the
".pdf" file extension at this time, so let's not over-rotate towards
generality.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1743914 - Part 3: Telemetry for when Firefox is the default handler. r?chutten!,mhowell!

This is Windows 10+ only, since we really only care about PDF handling
defaults where Edgium is the OS default.

The model, _isDefaultBrowser, is extremely defensive. I don't think
that level of defensive programming is justified here. If
ShellService.jsm doesn't exist, or doesn't pass through to the
underlying XPCOM shell service, or fails on non-Windows operating
systems -- that's all fine.

Depends on D132658

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1743914 - Part 2: Allow to experiment with setting Firefox as default PDF handler on Windows 10+. r?mhowell!,mardak!

Depends on D132659

Comment 4

[Masatoshi Kimura [:emk]]

Could you please not taking over .pdf handler from Acrobat Reader? (It is fine to take over from Edge/Edgium.)

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Masatoshi Kimura [:emk] from comment #4)

Could you please not taking over .pdf handler from Acrobat Reader? (It is fine to take over from Edge/Edgium.)

:emk: request noted. This particular ticket is about enabling the simplest possible experimentation, just changing what set to default means to include PDF handler. If it's worth it, we'll want to do something where we give users more options around PDF handling. I've been using the term "respectful" to mean that we don't trample non-default (i.e., non MSEdgePDF) user choices.

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: 1743914-data-review-1.md

Comment 7

[Chris H-C :chutten]

Comment on attachment 9254456 [details]
1743914-data-review-1.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in six months.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20713ede0c08
Part 1: Allow UserChoice to set Firefox as the default handler for arbitrary file extensions. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/7cb74ac80d41
Part 2: Allow to experiment with setting Firefox as default PDF handler on Windows 10+. r=mhowell,Mardak
https://hg.mozilla.org/integration/autoland/rev/088401e43bd4
Part 3: Telemetry for when Firefox is the default handler. r=chutten,mhowell

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_setDefaultPDFHandler.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/2ee98d9d6ecbf92be513f95c6b699554edf84053
Log link: https://treeherder.mozilla.org/logviewer?job_id=360870589&repo=autoland&lineNumber=2131

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57d0f8824e35
Part 1: Allow UserChoice to set Firefox as the default handler for arbitrary file extensions. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/c46d66869d03
Part 2: Allow to experiment with setting Firefox as default PDF handler on Windows 10+. r=mhowell,Mardak
https://hg.mozilla.org/integration/autoland/rev/01e19b8ec15b
Part 3: Telemetry for when Firefox is the default handler. r=chutten,mhowell

Comment 11

[Nick Alexander :nalexander [he/him]]

This was backed out 'cuz the test API for Nimbus changed overnight. Relanded after rebasing and updating the test API.

Comment 12

[Atila Butkovits]

Backed out for causing failures at browser_setDefaultPDFHandler.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/da3376c0199f8deaaa276f3377c2aa41f75313fb

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=DDT8DxHuSXa1zOrNr_h83g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=01e19b8ec15b7cf88af181b43b1a7e2003ca52af

Failure log: https://treeherder.mozilla.org/logviewer?job_id=360885187&repo=autoland&lineNumber=4970

Comment 13

[Nick Alexander :nalexander [he/him]]

Try push with a green Win7 bc test: https://treeherder.mozilla.org/jobs?repo=try&revision=31a44439b489028712db5777699d4a8fe8295220. Relanding.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05b9d17d7a0a
Part 1: Allow UserChoice to set Firefox as the default handler for arbitrary file extensions. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/39ca047920ba
Part 2: Allow to experiment with setting Firefox as default PDF handler on Windows 10+. r=mhowell,Mardak
https://hg.mozilla.org/integration/autoland/rev/ce23c0066bac
Part 3: Telemetry for when Firefox is the default handler. r=chutten,mhowell

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/05b9d17d7a0a
https://hg.mozilla.org/mozilla-central/rev/39ca047920ba
https://hg.mozilla.org/mozilla-central/rev/ce23c0066bac

Comment 16

[Andrei Purice]

QA has performed a check on the latest version of Firefox Nightly 97.0a1 (2021-12-14) and can confirm that the browser can be set as the default pdf handler. Firefox is registered as the default pdf handler (checked with registry editor and as well with the Windows default apps settings).
This was tested on Windows 10.