Closed Bug 1743917 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31820 - Fix web-exposed First Input Delay computation for desktop.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox97 fixed)

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31820 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31820
Details from upstream follow.

Hongbo Song <hbsong@google.com> wrote:

Fix web-exposed First Input Delay computation for desktop.

On desktop, when we click, the input event sequence would be pointerdown
,mousedown, pointerup, mouseup. The first input should be the
pointerdown. But our current FID computation would regard the mousedown
as the first input. And the input delay for the mousedown and
pointerdown can be different. This CL is to fix the web-exposed FID by
delaying reporting the mousedown until we receive a mouseup.

Bug: 1159951
Change-Id: I04f32745558885c6200f779570b6975ca1f4663a
Reviewed-on: https://chromium-review.googlesource.com/3308556
WPT-Export-Revision: e3da6cc5a316e7fd6b41c9daa0a2cc1dc580f462

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 36 tests and 1 subtests

Status Summary

Firefox

OK : 36
PASS: 27
FAIL: 9

Chrome

OK : 36
PASS: 30
FAIL: 6

Safari

OK : 36
FAIL: 36

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/event-timing/click-interactionid.html
Event Timing: compare event timing interactionId.: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/crossiframe.html
Event Timing: entries should only be observable by its own frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/event-timing/disconnect-target.html
Event Timing: when target is disconnected, entry.target returns null.: FAIL (Chrome: FAIL, Safari: FAIL)
/event-timing/event-retarget.html
Event Timing: target reports the last Event Target, i.e. nothing from shadow DOM.: FAIL (Chrome: FAIL, Safari: FAIL)
/event-timing/only-observe-firstInput.html
Event Timing: check first-input for a PerformanceObserver observing only first-input.: FAIL (Chrome: FAIL, Safari: FAIL)
/event-timing/programmatic-click-not-observed.html
Event Timing: events from programmatic click are not observed: FAIL (Chrome: FAIL, Safari: FAIL)
/event-timing/retrieve-firstInput.html
Event Timing: check first-input after onload, observer, click, click.: FAIL (Chrome: FAIL, Safari: FAIL)
/layout-instability/input-timestamp.html
Layout shift right after user input is observable via PerformanceObserver.: FAIL (Chrome: PASS, Safari: FAIL)
/layout-instability/recent-input.html
Layout shift right after user input is observable via PerformanceObserver.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f47e7d5bdfd4
[wpt PR 31820] - Fix web-exposed First Input Delay computation for desktop., a=testonly
https://hg.mozilla.org/integration/autoland/rev/3b52d5f52dd6
[wpt PR 31820] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f47e7d5bdfd4
https://hg.mozilla.org/mozilla-central/rev/3b52d5f52dd6

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.