Closed Bug 1743949 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31825 - [GridFragmentation] Basic support of break-before/break-after on item.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31825 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31825
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[GridFragmentation] Basic support of break-before/break-after on item.

This implements basic support for break-before/break-after. At the
moment it only support the top level break-before/break-after value (not
the nested values, until we set up the non-fragmented constraint space
correctly).

The break-before/break-after values are collected at the grid row level
when we calculate the grid (stored in a vector).

Currently this also doesn't (yet) search for the row with the highest
appeal.

Bug: 614667
Change-Id: I0299fa5d7b04106641903607c84fe45470f8a27c

Reviewed-on: https://chromium-review.googlesource.com/3287251
WPT-Export-Revision: 2c546fcb210738874ac13182b4e38dee425c10f9

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 3

Chrome

FAIL: 3

Safari

FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4612d56f2be6
[wpt PR 31825] - [GridFragmentation] Basic support of break-before/break-after on item., a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.