1743975 - TransitiveCompileOptions.{borrowBuffer,usePinnedBytecode} aren't copied by copyPODTransitiveOptions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Tooru Fujisawa [:arai]]

POD fields must be explicitly copied in TransitiveCompileOptions::copyPODTransitiveOptions, but TransitiveCompileOptions.{borrowBuffer,usePinnedBytecode} aren't handled here.

https://searchfox.org/mozilla-central/rev/3d03a3ca09f03f06ef46a511446537563f62a0c6/js/src/jsapi.cpp#2284-2308

void JS::TransitiveCompileOptions::copyPODTransitiveOptions(
    const TransitiveCompileOptions& rhs) {
  mutedErrors_ = rhs.mutedErrors_;
  forceFullParse_ = rhs.forceFullParse_;
  forceStrictMode_ = rhs.forceStrictMode_;
  skipFilenameValidation_ = rhs.skipFilenameValidation_;
  sourcePragmas_ = rhs.sourcePragmas_;
  selfHostingMode = rhs.selfHostingMode;
  asmJSOption = rhs.asmJSOption;
  throwOnAsmJSValidationFailureOption = rhs.throwOnAsmJSValidationFailureOption;
  forceAsync = rhs.forceAsync;
  discardSource = rhs.discardSource;
  sourceIsLazy = rhs.sourceIsLazy;
  introductionType = rhs.introductionType;
  introductionLineno = rhs.introductionLineno;
  introductionOffset = rhs.introductionOffset;
  hasIntroductionInfo = rhs.hasIntroductionInfo;
  hideScriptFromDebugger_ = rhs.hideScriptFromDebugger_;
  deferDebugMetadata_ = rhs.deferDebugMetadata_;
  nonSyntacticScope = rhs.nonSyntacticScope;
  privateClassFields = rhs.privateClassFields;
  privateClassMethods = rhs.privateClassMethods;
  classStaticBlocks = rhs.classStaticBlocks;
  useFdlibmForSinCosTan = rhs.useFdlibmForSinCosTan;
};

it results in those fields aren't reflected to off-thread task, and we're not using pinned-bytecode for them.

Comment 1

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/jobs?repo=try&revision=910fd57e4854e8c149950f732ddcb979f68e5919
https://treeherder.mozilla.org/jobs?repo=try&revision=bdcc5ed96099e839a7ae0e66c76a254a49a91370
ASAN: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=6efd60cdadba7d54d22b3b3b81784f50f3a14fd1

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1743975 - Copy all POD fields in TransitiveCompileOptions::copyPODTransitiveOptions. r?tcampbell!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a52ea6cdb79a
Copy all POD fields in TransitiveCompileOptions::copyPODTransitiveOptions. r=tcampbell

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a52ea6cdb79a