1744026 - Layout issues on `about:compat` in mobile browsers

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Dennis Schubert [:denschub]]

The addition of SmartBlock Fixes to about:compat breaks the layout on mobile. The tab bar should be scrollable or extend its height. I'll attach three screenshots to this bug:

• portrait-default.png: The default view, showing how it looks like if the default tab is selected. You'll notice the overlapping "SmartBlock Fixes" label.
• portrait-selected.png: How it looks like if you select the "SmartBlock Fixes" tab. For some reason, the tabbar extends its height here.
  landscape.png: In landscape mode, everything looks fine.

Comment 1

[Dennis Schubert [:denschub]]

Attachment: portrait-default.png

Comment 2

[Dennis Schubert [:denschub]]

Attachment: portrait-selected.png

Comment 3

[Dennis Schubert [:denschub]]

Attachment: landscape.png

Comment 4

[Dennis Schubert [:denschub]]

I'll land the code anyway, without reverting that patch, just to get the new interventions released. This isn't ideal, but...

Comment 5

[Thomas Wisniewski [:twisniewski]]

A PR fixing this has been uploaded here: https://github.com/mozilla-extensions/webcompat-addon/pull/253

Comment 6

[Dennis Schubert [:denschub]]

Attachment: GitHub Pull Request

Comment 7

[Dennis Schubert [:denschub]]

Attachment: Bug 1744026 - Import WebCompat Interventions v29.1.0 sources.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c76bac637a0
Import WebCompat Interventions v29.1.0 sources. r=karlcow

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing mochitest failures on browser_parsable_css.js. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/6a1a3c3fcbda4c0ead348ab4d248a2a7bbda34b3

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=7c76bac637a07dd71d4fbbe0841915c0a09bccd7&selectedTaskRun=UAUaOz2RRgCn7ryKD1cNmQ.0

Link to failure log: https://treeherder.mozilla.org/logviewer?job_id=360250850&repo=autoland&lineNumber=2708

Failure message :
TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for jar:file:///builds/worker/workspace/build/application/firefox/browser/features/[e-mail]!/about-compat/aboutCompat.css: Error in parsing value for ‘grid-template-rows’. Declaration dropped. -

Comment 10

[Dennis Schubert [:denschub]]

Oh well, the reviewbot task didn't even run that lint.

Comment 11

[Dennis Schubert [:denschub]]

Updated the patch. browser_parsable_css.js. passes locally (and by "passes", I mean that none of the failures are caused by our CSS).

Try push to confirm before relanding: https://treeherder.mozilla.org/jobs?repo=try&revision=72191c859bc17a96bc1386bb5d253c5d338b16b7

Comment 12

[Dennis Schubert [:denschub]]

Try run finished, none of the failures in that push look related to this change. Landing again.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d60ac4cfc481
Import WebCompat Interventions v29.1.0 sources. r=karlcow

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d60ac4cfc481

Comment 15

[Dennis Schubert [:denschub]]

I'm setting firefox96:wontfix. The only place you'd ever see this is in GeckoViewExample. On Desktop, you'd have to manually enable RDM with Touch Events to even see this, and I've deliberately delayed the android-components PR for this, so Fenix etc never received the version with this issue. We could just uplift that patch, but given this shouldn't affect anyone, that's imho not worth it.