Closed Bug 1744115 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31854 - [SelectMenu] Reflect option.selected for selectmenu.value

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31854 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31854
Details from upstream follow.

Ionel Popescu <iopopesc@microsoft.com> wrote:

[SelectMenu] Reflect option.selected for selectmenu.value

This CL adds support so that updating option.selected will also update
selectmenu.value.

When the selected value is true, the option is marked as selectmenu's
selectedOption. For now, when the selected value is changed to false,
the first option is going to be selected (support for reset to default
selection is going to be added in a follow up CL).

Bug: 1121840
Change-Id: I7f4b9de685cefeb2f549a3e39b1c69f555490d90
Reviewed-on: https://chromium-review.googlesource.com/3287417
WPT-Export-Revision: 678613ee78a1223b4f2f088e4f253f82fa1a8f7b

PR 31854 applied with additional changes from upstream: 0695d6b2b0e1bdaa2020500b514ac542464a7ae5
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
FAIL: 8

Chrome

OK : 1
PASS: 6
FAIL: 2

Safari

OK : 1
FAIL: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-selectmenu-element/selectmenu-value.tentative.html
Test that HTMLSelectMenu with no options has empty string for value: FAIL (Chrome: PASS, Safari: FAIL)
Test value with HTMLOptionElement element option parts: FAIL (Chrome: PASS, Safari: FAIL)
Test value with non-HTMLOptionElement elements labeled as parts: FAIL (Chrome: PASS, Safari: FAIL)
Test that value is updated when options are removed: FAIL (Chrome: PASS, Safari: FAIL)
Test that slotted-in selected-value part is updated to value of selectmenu: FAIL (Chrome: PASS, Safari: FAIL)
Test that option parts in a slotted-in listbox are reflected in the value property: FAIL (Chrome: PASS, Safari: FAIL)
Test that value is correctly updated: FAIL (Chrome: FAIL, Safari: FAIL)
Test that HTMLOption.selected updates selectmenu.value: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d365321e6e1
[wpt PR 31854] - [SelectMenu] Reflect option.selected for selectmenu.value, a=testonly
https://hg.mozilla.org/integration/autoland/rev/880acfff7d14
[wpt PR 31854] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2d365321e6e1
https://hg.mozilla.org/mozilla-central/rev/880acfff7d14

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.