Closed Bug 1744124 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 31856 - [GridNG] Parsing of empty grid named lines for subgrid

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31856 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31856
Details from upstream follow.

Ana SollanoKim <ansollan@microsoft.com> wrote:

[GridNG] Parsing of empty grid named lines for subgrid

In this CL we introduce the parsing of empty grid named lines used in a
subgrid's line name list. A new variable was added to
|CSSGridLineNamesValue| to flag when there's an empty line and only
return the line separators. The web test grid-template-valid.html is now
a full pass and more cases with empty lines were added.

We'll address the serialization of empty lines in another CL, added a
TODO in |StyleBuilderConverter| to track it.

Bug: 618969
Change-Id: I55f55a1633d30ab94ca9b0046265e38c952f569f
Reviewed-on: https://chromium-review.googlesource.com/3308413
WPT-Export-Revision: a230c81370ddf44535386b21a5bfa6abfdbb8cb5

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 36 subtests

Status Summary

Firefox

OK : 1
PASS: 24
FAIL: 12

Chrome

OK : 1
FAIL: 36

Safari

OK : 1
FAIL: 36

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-grid/subgrid/grid-template-valid.html
e.style['grid-template-rows'] = "subgrid repeat(2, [a])" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-rows'] = "subgrid repeat(2, [a] [b])" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-rows'] = "subgrid [a] repeat(2, [b])" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-rows'] = "subgrid [a] repeat(2, [b]) [c]" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-rows'] = "subgrid [] repeat(2, []) []" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-rows'] = "subgrid [a] repeat(2, [b]) repeat(auto-fill, [c]) [d]" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-columns'] = "subgrid repeat(2, [a])" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-columns'] = "subgrid repeat(2, [a] [b])" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-columns'] = "subgrid [a] repeat(2, [b])" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-columns'] = "subgrid [a] repeat(2, [b]) [c]" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-columns'] = "subgrid [] repeat(2, []) []" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['grid-template-columns'] = "subgrid [a] repeat(2, [b]) repeat(auto-fill, [c]) [d]" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d98dcc8dcef [wpt PR 31856] - [GridNG] Parsing of empty grid named lines for subgrid, a=testonly https://hg.mozilla.org/integration/autoland/rev/00861282a474 [wpt PR 31856] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5d98dcc8dcef
https://hg.mozilla.org/mozilla-central/rev/00861282a474

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.