1744178 - Add public type for CompilationGCOuptut

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

In bug 1734098, I'm going to replace off-thread API purely on stencil, and let the consumer instantiate it on main thread.
In order to do that, we need to pass the CompilationGCOutput prepared in off-thread to the consumer, and let the consumer pass it back to instantiate API

Comment 1

[Tooru Fujisawa [:arai]]

Also, we could move the off-thread compilation/decode body to the embedding side, to utilize embedding's threading,
it will also require public type for pre-allocated/prepared CompilationGCOuptut that can be passed between threads.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1744178 - Add JS::InstantiationStorage. r?nbp!

In order to support allocating CompilationGCOutput off main thread with
stencil-based off-thread API, add public type that wraps CompilationGCOutput,
and make stencil-based off-thread API return pre-allocated CompilationGCOutput
if the options.allocateInstantiationStorage is true.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ca5bceb693c
Add JS::InstantiationStorage. r=nbp

Comment 4

[Iulian Moraru]

Backed out (bug 1744178, bug 1734098) for causing leaks.

Affected platform Linux 18.04 x64 WebRender asan opt

Push with failures

Failure log for wd leaks
Failure log for bc leaks
Other jobs have the same failure log as bc leaks.

Backout link

Also this V-swr bustages, failure log: https://treeherder.mozilla.org/logviewer?job_id=360715600&repo=autoland&lineNumber=71123
and
this py3 mch failures, failure log: https://treeherder.mozilla.org/logviewer?job_id=360720852&repo=autoland&lineNumber=181

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e5fbe48db65
Add JS::InstantiationStorage. r=nbp

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5e5fbe48db65