1744195 - [win] The disabled buttons from import and create new profile windows have hover and can be clicked

Status: VERIFIED FIXED

(Core :: Widget, defect)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: modal_00.gif

Affected versions

• 96.0a1 (20211202215058)
• 95.0 (20211129150630)

Affected platforms

• Windows10 x64

Steps to reproduce

1. Open Firefox and Import Wizard or Create a new profile window.
2. Hover or click on the Back button.

Expected result

• Back button is not displayed or cannot be hovered/ clicked.

Actual result

• Back button can be hovered and clicked.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1ff04e10cd2318b494c0f05777cd80291289d127&tochange=d39b23efefe7e7d89d8dfd0ba188ad6af2b0a9ed

Notes

• Screen recording attached.
• On Ubuntu 21.04 there is no Back button and on macOS 10.15 the Back button cannot be hovered or clicked.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Emilio, fyi.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1733569

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1744195 - Centralize XUL state checks in nsNativeTheme::GetContentState. r=mstange,spohl

This makes sure that the non-native theme and the native theme agree on
what's e.g. disabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cc085b16d94
Centralize XUL state checks in nsNativeTheme::GetContentState. r=mstange

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5cc085b16d94

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9254297 [details]
Bug 1744195 - Centralize XUL state checks in nsNativeTheme::GetContentState. r=mstange,spohl

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: commen t0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's not a one-liner but it's a relatively straight-forward patch that makes state checks consistent across native and non-native theme implementations.
• String changes made/needed: none

Comment 8

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9061914315ea

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9254297 [details]
Bug 1744195 - Centralize XUL state checks in nsNativeTheme::GetContentState. r=mstange,spohl

Approved for 96.0b5

Comment 10

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 96.0b5 (20211213210439) and 97.0a1 (20211213214351) on Windows 10x64.