1744202 - Crash in [@ abort | webrtc::internal::VideoSendStreamImpl::VideoSendStreamImpl] on facebook sites

Status: RESOLVED WORKSFORME

(Core :: WebRTC: Audio/Video, defect)

Description

[Pascal Chevrel:pascalc]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/682eaf8a-8814-4a85-b7db-559550211202

Reason: STATUS_STACK_BUFFER_OVERRUN / FAST_FAIL_FATAL_APP_EXIT

Top 10 frames of crashing thread:

0 ucrtbase.dll abort 
1 xul.dll rtc::FatalMessage::~FatalMessage third_party/libwebrtc/webrtc/rtc_base/checks.cc:69
2 xul.dll webrtc::internal::VideoSendStreamImpl::VideoSendStreamImpl third_party/libwebrtc/webrtc/video/video_send_stream.cc:796
3 xul.dll webrtc::internal::VideoSendStream::ConstructionTask::Run third_party/libwebrtc/webrtc/video/video_send_stream.cc:417
4 xul.dll rtc::TaskQueue::Impl::RunPendingTasks third_party/libwebrtc/webrtc/rtc_base/task_queue_win.cc:347
5 xul.dll rtc::TaskQueue::Impl::RunThreadMain third_party/libwebrtc/webrtc/rtc_base/task_queue_win.cc:384
6 xul.dll rtc::PlatformThread::Run third_party/libwebrtc/webrtc/rtc_base/platform_thread.cc:251
7 xul.dll static rtc::PlatformThread::StartThread third_party/libwebrtc/webrtc/rtc_base/platform_thread.cc:159
8 kernel32.dll BaseThreadInitThunk 
9 ntdll.dll RtlUserThreadStart 

Comment 1

[Pascal Chevrel:pascalc]

We have a spike of crashes with this signature since yesterday on all channels. Many comments about Facebook Messenger.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Peter: This is a crash on facebook sites (both facebook.com and messenger.com) and looks related to changes on their end because it also affects Firefox release and started yesterday.

Andreas: Can you investigate this webrtc crash?

Comment 3

[Andreas Pehrson [:pehrsons]]

Looks like we are letting through an rtp header extension for sent video that upstream (at least prior to bug 1654112) doesnt support. But I am not able to look into this today. Byron?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The crashes stopped. First crash report (except one on 2021-11-11) got submitted at 2021-12-02 21:05:59 UTC, last one at 2021-12-02 23:44:53. 708 crashes got submitted in total.

Comment 5

[Byron Campen [:bwc]]

It is hard to say exactly what happened here, but it looks like maybe this is a case of a duplicate extmap id slipping through the JSEP engine somehow? Or maybe something that libwebrtc thinks is a duplicate, but is not really? This duplicate business can get really hairy when bundle and rollback are involved. Is there a contact at Facebook that we can ask about this?

Comment 6

[Peter Saint-Andre [:stpeter]]

We have an email coordination list with Facebook related to WebRTC topics. I'll post there and cc the right Mozilla people.

Comment 7

[Byron Campen [:bwc]]

Based on the email response, it seems that somehow we are trying to configure an RTP extension that the JSEP engine does not actually support? That's just plain weird... I'm going to dig into this further.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.