1744225 - Perma mozbuild.preprocessor.Error: ('$SRCDIR/modules/libpref/init/StaticPrefList.yaml', 12354, 'UNDEFINED_VAR', 'EARLY_BETA_OR_EARLIER')

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Narcis Beleuzu [:NarcisB]]

Central-as-beta simulation:
https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2555405c206b671b95f4676ee3690b144e1b0f34
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=360066577&repo=try&lineNumber=1577

Comment 1

[Narcis Beleuzu [:NarcisB]]

Attachment: Bug 1744225 - Correct early beta variable name guarding preference in StaticPrefs.yaml

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1743525

Comment 3

[Narcis Beleuzu [:NarcisB]]

The patch fixes the issue :
https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=876d05bbfee6fa839aec96f56902422b85ce435f

Comment 4

[Sotaro Ikeda [:sotaro]]

Sorry. It was my mistake. I did not notice it since the problem did not happen on m-c :(

Comment 5

[Sotaro Ikeda [:sotaro]]

:NarcisB, are you going to check in the patch? Or do I need to do it?

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #5)

:NarcisB, are you going to check in the patch? Or do I need to do it?

Sorry, I just reviewed your patch, it was already requested me to review it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db7955ab0f0d
Correct early beta variable name guarding preference in StaticPrefs.yaml r=sotaro

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/db7955ab0f0d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval.

Comment 10

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9253590 [details]
Bug 1744225 - Correct early beta variable name guarding preference in StaticPrefs.yaml

Beta/Release Uplift Approval Request

• User impact if declined: Build might not work as expected.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It fixes wrong variable name. But it does not change how window occlusion work.
• String changes made/needed: None

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9253590 [details]
Bug 1744225 - Correct early beta variable name guarding preference in StaticPrefs.yaml

Approved for 96.0b3

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/177b9b34f45e

Comment 13

[Andreea Pavel [:apavel]]

Verified fixed in latest beta sim: https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2e942e8d46615c85bf9f6f65dc5723e1aad92256&group_state=expanded