Closed
Bug 1744254
Opened 2 years ago
Closed 2 years ago
[VA-API] Don't try to use VA-API on unsupported formats
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
98 Branch
Tracking | Status | |
---|---|---|
firefox98 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
Right now we try VA-API decode regardless of supported formats. We should check supported format first and then try VA-API decoding and fall back to SW decode for the rest.
Assignee | ||
Comment 1•2 years ago
|
||
We can use libva directly to get supported formats - call vaQueryConfigProfiles() or similar.
Assignee | ||
Comment 2•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → stransky
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•2 years ago
|
||
Depends on D135131
Assignee | ||
Comment 4•2 years ago
|
||
- Use bundled va library headers from media/ffvpx instead of forward declaration.
- Link mozva (libva wrapper) with ffmpeg58/ffvpx as we need va library to enumerate VA-API formats.
Depends on D135132
Assignee | ||
Comment 5•2 years ago
|
||
In this patch we do:
- Enumerate supported VA-API profiles and check supported pixel formats (we can import only VN12 and YUV420P from VA-API).
- Store supported formats at mAcceleratedFormats static array to speed up future checks.
- Check supported VA-API format/codec and fall back to SW decode on decoder level.
- Create mVideoFramePool later when we know actual AV-API state.
- Use va/va.h from media/ffvpx instead of forward declared defines
Depends on D135134
Assignee | ||
Comment 7•2 years ago
|
||
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/3f107a153ad9 Export ffmpeg routines needed for VA-API formats enumeration, r=alwu,media-playback-reviewers https://hg.mozilla.org/integration/autoland/rev/181370e93cab Export VA library routines needed for VA-API formats enumeration r=alwu https://hg.mozilla.org/integration/autoland/rev/72c3b9812b35 Use bundled va library from media/ffvpx instead of forward declaration r=alwu,media-playback-reviewers https://hg.mozilla.org/integration/autoland/rev/16337f126487 Check supported VA-API codecs/formats r=alwu,media-playback-reviewers
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0e7e39e68cb9 Fix black lint. r=fix CLOSED TREE
Comment 10•2 years ago
•
|
||
Flags: needinfo?(stransky)
Comment 11•2 years ago
|
||
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/3c70d11636bc Export ffmpeg routines needed for VA-API formats enumeration, r=alwu,media-playback-reviewers https://hg.mozilla.org/integration/autoland/rev/b2f2b2751499 Export VA library routines needed for VA-API formats enumeration r=alwu https://hg.mozilla.org/integration/autoland/rev/59f4e0a476ac Use bundled va library from media/ffvpx instead of forward declaration r=alwu,media-playback-reviewers https://hg.mozilla.org/integration/autoland/rev/97ddb4b0f1c9 Check supported VA-API codecs/formats r=alwu,media-playback-reviewers
Comment 12•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3c70d11636bc
https://hg.mozilla.org/mozilla-central/rev/b2f2b2751499
https://hg.mozilla.org/mozilla-central/rev/59f4e0a476ac
https://hg.mozilla.org/mozilla-central/rev/97ddb4b0f1c9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox98:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(stransky)
You need to log in
before you can comment on or make changes to this bug.
Description
•