1744287 - More from Mozilla section shows up below the fold when accessing settings/preferences

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

More From Mozilla section is missing a hidden attribute , which is causing this newly added section to show up below the fold on about:preferences refresh or accessing via url
STR

1. Click Application Menu -> Settings
2. Open about:preferences with 'More From Mozilla' section below the fold

Fix is to add hidden=true for moreFromMozillaCategory here https://searchfox.org/mozilla-central/source/browser/components/preferences/moreFromMozilla.inc.xhtml#12

Comment 1

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:

This fix impacts both 95 and 96. This issue will be seen by Fx 95 'More From Mozilla' experiment users enrolled in treatment branch. It will be good to uplift or ride next dot release if possible, will submit patch for review

Comment 2

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:
Putting it for tracking for 95 to get release feedback if its possible today to uplift this patch to 95 thanks!

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1744287 - More from Mozilla section shows up below the fold

Comment 4

[Punam Dahiya [:pdahiya]]

This bug touches Fx 95 experiment https://mana.mozilla.org/wiki/pages/viewpage.action?spaceKey=FPS&title=More+from+Mozilla+-+Fx95 . In below cases, will result in showing More From Mozilla section below the fold to users enrolled in treatment branch of Fx95 experiment

a) When user access Settings from Firefox Menu
b) On refresh of about:preferences

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71838bb6c080
More from Mozilla section shows up below the fold r=preferences-reviewers,Gijs

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/71838bb6c080

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Tracking as a ride along for a potential dot release during the 95 cycle.

Comment 8

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the "More From Mozilla" content is no longer displayed in any other pane from the "about:preferences" page using Firefox Beta 96.0b2 (Build ID: 20211207185904) en-US on Windows 10 x64, macOS 11.6, and Ubuntu Linux 20.04 x64.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Punam, could you request an uplift to mozilla-release? Thanks
(video showing how the uplift request form is triggered: https://video.chevrel.org/demos/upliftRequestForm.mp4)

Comment 10

[:Gijs (he/him)]

Comment on attachment 9253654 [details]
Bug 1744287 - More from Mozilla section shows up below the fold

Beta/Release Uplift Approval Request

• User impact if declined: Unexpected content in prefs for people in the experiment
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See earlier comments
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial attribute addition
• String changes made/needed: Nope

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9253654 [details]
Bug 1744287 - More from Mozilla section shows up below the fold

Approved for a 95 dot release, thanks.

Comment 12

[Punam Dahiya [:pdahiya]]

thanks @gijs @pascal!

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-release/rev/a957e0dc0144

Comment 14

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the "More From Mozilla" content is no longer displayed in any other pane from the "about:preferences" page using Firefox Release 95.0.1 (Build ID: 20211215221728) en-US and the latest Firefox Beta 96.0b5 (Build ID: 20211214203716) en-US on Windows 10 x64, macOS 11.6, and Ubuntu Linux 20.04 x64.